-
-
Notifications
You must be signed in to change notification settings - Fork 831
Conversation
- Get rid of the ugly text and red shields on every single message - Add a single banner at the top of the room view explaining what's wrong, and offering a clear call to action when possible - Send key requests automatically instead of prompting the user to click a link/button - Prompt the user to verify their device as a first step if it isn't verified yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearing review request until after Design review
Codecov Report
@@ Coverage Diff @@
## develop #8272 +/- ##
===========================================
- Coverage 30.05% 30.03% -0.02%
===========================================
Files 881 883 +2
Lines 50240 50301 +61
Branches 12799 12802 +3
===========================================
+ Hits 15099 15108 +9
- Misses 35141 35193 +52
|
…ith message bubbles
It's looking great, thanks for working on this. I am proposing a few visual changes to make the errors clearer.
Sharing Figma file with all the proposed changes Link. Thank you! |
@amshakal Thanks for the feedback! Did you see the updated screenshots in my comments at the top of this thread? It's already got calls to action and text-based error messages. I got rid of the asterisks because it seemed stylistically bad, but I can put them back if you think it's an improvement; instead, I added grey key icons to distinguish those messages as errors without overwhelming the user with too much red. For the text of those messages, I went with "unable to decrypt message" rather than "waiting to decrypt message", because it's not necessarily clear what we'd be "waiting" for, and in some cases there might not be anything to wait for at all. Does that sound ok? The multi-line banner styling is a great idea, I'll get working on that. Thank you! |
All sounds good to me! |
It's looking great. Thanks @duxovni 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking exciting
Have made some comments
But also this could really do with tests being written as it has a lot of edges which will miss being exercised regularly
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
Closing in favor of #9544. |
Screenshots
New decryption error UI
Show a loading spinner for the first 5 seconds
If this device isn't verified, and there are other devices or backups that could help it decrypt messages, prompt to verify first
If this device is verified and there are other verified devices, prompt to open one of them
If this is the only verified device, not much the user can do, so just explain the current status
If this device is unverified, and there's nothing for it to verify against, all we can do is reset keys
Dark mode, message bubbles
Here's what your changelog entry will look like:
✨ Features
Preview: https://pr8272--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.