-
Notifications
You must be signed in to change notification settings - Fork 357
feat: store the thread subscription status in the database #5455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #5455 will not alter performanceComparing Summary
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5455 +/- ##
==========================================
+ Coverage 88.88% 88.90% +0.01%
==========================================
Files 333 333
Lines 92082 92228 +146
Branches 92082 92228 +146
==========================================
+ Hits 81850 81995 +145
+ Misses 6403 6393 -10
- Partials 3829 3840 +11 ☔ View full report in Codecov by Sentry. |
stefanceriu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, lgtm 👍
59dbf89 to
d2d9b9c
Compare
stefanceriu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still lgtm 👍
…eturn something more precise than unknown when fetching a subscription
03585ce to
4e565ab
Compare
Some implementation notes:
StateStoreDataKeyet al.), I've added a new table for the thread subscriptions, so we can later do queries like "where status is subscribed".Part of #5038