Remove C-S unsigned data from PDU definitions
#3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a bunch of fields from the `unsigned` property of PDUs. These things shouldn't be passed over the Federation API, and they *really* shouldn't be trusted if they are sent by another server. * `replaces_state` *is* returned by Synapse, but probably shouldn't be. * `redacted_because`, `prev_sender` and `prev_content` are not sent by Synapse.
turt2live
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a bunch of fields from the
unsignedproperty of PDUs. These things shouldn't be passed over the Federation API, and they really shouldn't be trusted if they are sent by another server. (See also matrix-org/synapse#11080)replaces_stateis returned by Synapse, but probably shouldn't be.redacted_because,prev_senderandprev_contentare not sent by Synapse.Preview: https://pr3522--matrix-org-previews.netlify.app