clarify federation Authorization header an add destination property #1067
Conversation
|
@uhoreg is this ready for review? |
|
Should be ready now |
| @@ -2,7 +2,7 @@ | |||
| {{ $this := .Params.this }} | |||
|
|
|||
| {{ if $this }} | |||
| <span>**[New in this version]**</span> | |||
There was a problem hiding this comment.
These changes are needed, otherwise it displays the markdown in the federation docs, rather than the HTML
There was a problem hiding this comment.
hmm.. that's surprising. What version of hugo?
There was a problem hiding this comment.
It happened with whatever version of hugo CI was using. It worked fine in the CS bits. I assume it's because it got substituted in, and then the file got included in the main file, and then reprocessed. But it didn't work for the federation doc.
There was a problem hiding this comment.
right, yea. {{< shortcode >}} is a literal while {{% shortcode %}} is interpreted - we need to use angle brackets to get the inline stuff to work, annoyingly.
There was a problem hiding this comment.
This is fun though (and not worth fixing in this PR, I think):
s2s spec:
c2s spec:
The code blocks are different. I think it's because of the table structure, but not really sure.
|
#511 which is sort-of related will be solved separately, because it's a bigger change I'll assume? Ofher than that, this looks hood to me. Thanks! |
Oh, I didn't notice that one. Yes, I think that would be a separate PR. I think I'm already stretching it, making three changes in 1 PR. |
| @@ -2,7 +2,7 @@ | |||
| {{ $this := .Params.this }} | |||
|
|
|||
| {{ if $this }} | |||
| <span>**[New in this version]**</span> | |||
There was a problem hiding this comment.
This is fun though (and not worth fixing in this PR, I think):
s2s spec:
c2s spec:
The code blocks are different. I think it's because of the table structure, but not really sure.
spec PR for matrix-org/matrix-spec-proposals#3383
fixes #817
Preview: https://pr1067--matrix-spec-previews.netlify.app