Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Make all rooms noisy by default #60

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Make all rooms noisy by default #60

merged 3 commits into from
Sep 18, 2020

Conversation

MatMaul
Copy link
Contributor

@MatMaul MatMaul commented Sep 8, 2020

No description provided.

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested on Preprod

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally changing the base push rules are scary, but this doesn't change any logic except changing highlight - > highlight + noise, so LGTM.

@anoadragon453 anoadragon453 merged commit b8d7ca9 into dinsic Sep 18, 2020
anoadragon453 added a commit that referenced this pull request Oct 9, 2020
…oa/freeze_rooms

* 'dinsic' of github.com:matrix-org/synapse-dinsic:
  Only assert valid next_link params when provided (#65)
  Don't push if an user account has expired (#58)
  Swap method calls in RoomAccessTestCase.test_change_rules (#64)
  Make all rooms noisy by default (#60)
  Make AccessRules use the public rooms directory instead of checking a room's join rules on rule change (#63)
  Override the power levels defaults, enforce mod requirement for invites, admin requirements for unknown state events (#61)
  RoomAccessRules cleanup (#62)
  Add a config option for validating 'next_link' parameters against a domain whitelist (#8275)
@MatMaul MatMaul deleted the mv/noisy-notifs branch December 14, 2020 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants