From 0fe647a289869346e6495f7e7fe584f051d91823 Mon Sep 17 00:00:00 2001 From: Erik Johnston Date: Mon, 12 Jun 2023 11:03:48 +0100 Subject: [PATCH] Log when we delete rows that do not match constraint --- synapse/storage/background_updates.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/synapse/storage/background_updates.py b/synapse/storage/background_updates.py index 0b95885be89d..85a928762738 100644 --- a/synapse/storage/background_updates.py +++ b/synapse/storage/background_updates.py @@ -931,9 +931,15 @@ def validate_constraint_in_background_check( to_delete = [row[:-1] for row in rows if not row[-1]] - self.db_pool.simple_delete_many_batch_txn( - txn, table=table, keys=unique_columns, values=to_delete - ) + if to_delete: + logger.warning( + "Deleting %d rows that do not pass new constraint", + len(to_delete), + ) + + self.db_pool.simple_delete_many_batch_txn( + txn, table=table, keys=unique_columns, values=to_delete + ) self._background_update_progress_txn( txn, update_name, new_progress.dict()