Docker: remove VOLUME directive (#11997)

The driver for this is to stop Complement complaining about it, but as far as I can tell it was pointless and needed to go away anyway. I'm a bit unclear about what exactly VOLUME does, but I think what it means is that, if you don't override it with an explicit -v argument, then docker run will create a temporary volume, and copy things into it. The temporary volume is then deleted when the container finishes. That only sounds useful if your image has something to copy into it (otherwise you may as well just use the default root filesystem), and our image notably doesn't copy anything into /data. So... this wasn't doing anything, except annoying Complement?
matrix-org · Feb 15, 2022 · 5598556 · 5598556
1 parent e44f91d
commit 5598556
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/changelog.d/11997.docker b/changelog.d/11997.docker
@@ -0,0 +1 @@
+The docker image no longer automatically creates a temporary volume at `/data`. This is not expected to affect normal usage.
diff --git a/docker/Dockerfile b/docker/Dockerfile
@@ -98,8 +98,6 @@ COPY --from=builder /install /usr/local
 COPY ./docker/start.py /start.py
 COPY ./docker/conf /conf
 
-VOLUME ["/data"]
-
 EXPOSE 8008/tcp 8009/tcp 8448/tcp
 
 ENTRYPOINT ["/start.py"]
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		The docker image no longer automatically creates a temporary volume at `/data`. This is not expected to affect normal usage.