Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Remove POST method from password reset submit_token endpoint (#6056)
Browse files Browse the repository at this point in the history
Removes the POST method from `/password_reset/<medium>/submit_token/` as it's only used by phone number verification which Synapse does not support yet.
  • Loading branch information
anoadragon453 authored Sep 19, 2019
1 parent 38fd1f8 commit 62e3ff9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 17 deletions.
1 change: 1 addition & 0 deletions changelog.d/6056.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove POST method from password reset submit_token endpoint until we implement submit_url functionality.
17 changes: 0 additions & 17 deletions synapse/rest/client/v2_alpha/account.py
Original file line number Diff line number Diff line change
Expand Up @@ -272,23 +272,6 @@ def on_GET(self, request, medium):
request.write(html.encode("utf-8"))
finish_request(request)

@defer.inlineCallbacks
def on_POST(self, request, medium):
if medium != "email":
raise SynapseError(
400, "This medium is currently not supported for password resets"
)

body = parse_json_object_from_request(request)
assert_params_in_dict(body, ["sid", "client_secret", "token"])

valid, _ = yield self.store.validate_threepid_session(
body["sid"], body["client_secret"], body["token"], self.clock.time_msec()
)
response_code = 200 if valid else 400

return response_code, {"success": valid}


class PasswordRestServlet(RestServlet):
PATTERNS = client_patterns("/account/password$")
Expand Down

0 comments on commit 62e3ff9

Please sign in to comment.