From af21fbb33824977a392ffc4c7875b800901a3328 Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Thu, 25 Jun 2020 11:05:52 +0100 Subject: [PATCH] Simplify medium and address assignment --- synapse/rest/client/v1/login.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/synapse/rest/client/v1/login.py b/synapse/rest/client/v1/login.py index 98a3365f05fc..b90ad6d79eb0 100644 --- a/synapse/rest/client/v1/login.py +++ b/synapse/rest/client/v1/login.py @@ -144,10 +144,8 @@ async def _do_other_login(self, login_submission): # Check whether this attempt uses a threepid, if so, check if our failed attempt # ratelimiter allows another attempt at this time - medium, address = ( - login_submission.get("medium"), - login_submission.get("address"), - ) + medium = login_submission.get("medium") + address = login_submission.get("address") if medium and address: self._failed_attempts_ratelimiter.ratelimit( (medium, address.lower()), update=False