Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Add comment describing why we do not answer make_joins
Browse files Browse the repository at this point in the history
  • Loading branch information
reivilibre committed Aug 4, 2022
1 parent 72c3f78 commit de620ba
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions synapse/handlers/federation.py
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,10 @@ async def on_make_join_request(
# If our server is still only partially joined, we can't give a complete
# response to /make_join, so return a 404 as we would if we weren't in the
# room at all.
# The main reason we can't respond properly is that we need to know about
# the auth events for the join event that we would return.
# Another reason is that we should not entertain the make_join since we
# cannot handle the send_join.
logger.info(
"Rejecting /make_join to %s because it's a partial state room", room_id
)
Expand Down

0 comments on commit de620ba

Please sign in to comment.