Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove legacy structured logging configuration #12006

Closed
clokep opened this issue Feb 16, 2022 · 4 comments · Fixed by #12008 or #12392
Closed

Remove legacy structured logging configuration #12006

clokep opened this issue Feb 16, 2022 · 4 comments · Fixed by #12008 or #12392
Assignees
@clokep
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@clokep
Copy link
Member

clokep commented Feb 16, 2022

See setup_structured_logging and the helpers it uses (bits about drains and such). There are also some bits in the documentation.
@clokep clokep added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Feb 16, 2022
@clokep clokep changed the title Deprecate and remove legacy structured logging configuration Remove legacy structured logging configuration Feb 16, 2022
@clokep
Copy link
Member Author

clokep commented Feb 16, 2022

Looks like we deprecated this in v1.23.0: https://matrix-org.github.io/synapse/latest/upgrade.html#structured-logging-configuration-breaking-changes

@clokep clokep mentioned this issue Feb 16, 2022
Merged
@clokep clokep self-assigned this Feb 16, 2022
@clokep
Copy link
Member Author

clokep commented Feb 17, 2022

I'm going to re-open this, we should remove the upgrade docs at some point in the future (maybe in 1.56?)

@clokep clokep reopened this Feb 17, 2022
@MadLittleMods
Copy link
Contributor

@clokep giving this a ping because 1.56.0 was just released 🙇

@clokep clokep mentioned this issue Apr 6, 2022
Merged
@clokep
Copy link
Member Author

clokep commented Apr 6, 2022

Thanks for the reminder!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
2 participants
@clokep @MadLittleMods