Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Workaround pip bug installing latest treq and not-latest twisted from hashes #12439

Merged
merged 7 commits into from
Apr 12, 2022
Merged

Workaround pip bug installing latest treq and not-latest twisted from hashes #12439

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9007f35
Workaround poetry export bug with recent twisted
Apr 11, 2022
1e2fab6
Changelog
Apr 11, 2022
e24ecf1
Patch requirements.txt to workaround twisted pain
Apr 11, 2022
a0db7ce
Revert "Workaround poetry export bug with recent twisted"
Apr 11, 2022
c4b6b93
Update changelog
Apr 11, 2022
38b59e5
Install deps with `--no-deps`
Apr 11, 2022
8a71bfb
Revert "Patch requirements.txt to workaround twisted pain"
Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/12439.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Bundle locked versions of dependencies into the Docker image.
5 changes: 5 additions & 0 deletions docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ COPY pyproject.toml poetry.lock README.rst /synapse/

RUN /root/.local/bin/poetry export --extras all -o /synapse/requirements.txt

# Workaround https://github.com/pypa/pip/issues/9644. Without this, pip tries to install
# Twisted[tls] using the latest twisted and fails; it doesn't realisie that there is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Twisted[tls] using the latest twisted and fails; it doesn't realisie that there is
# Twisted[tls] using the latest twisted and fails; it doesn't realise that there is

# already a version of twisted given in the requirments.
RUN sed -i /synapse/requirements.txt -e 's/^twisted==/twisted[tls]==/'

###
### Stage 1: builder
###
Expand Down