From be7f3bd2a54d9563e15f565a7797d5ca67889f5d Mon Sep 17 00:00:00 2001 From: "Amber H. Brown" Date: Wed, 26 Jun 2019 15:35:57 +1000 Subject: [PATCH 1/4] oh my god shut up --- synapse/metrics/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/synapse/metrics/__init__.py b/synapse/metrics/__init__.py index 1f30179b5169..7d7fcdb9d0d3 100644 --- a/synapse/metrics/__init__.py +++ b/synapse/metrics/__init__.py @@ -437,7 +437,7 @@ def f(*args, **kwargs): counts = gc.get_count() for i in (2, 1, 0): if threshold[i] < counts[i]: - logger.info("Collecting gc %d", i) + logger.debug("Collecting gc %d", i) start = time.time() unreachable = gc.collect(i) From 3a393ba8e626c0eff6efeb177718b765a770a065 Mon Sep 17 00:00:00 2001 From: "Amber H. Brown" Date: Wed, 26 Jun 2019 15:36:33 +1000 Subject: [PATCH 2/4] changelog --- changelog.d/5557.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/5557.misc diff --git a/changelog.d/5557.misc b/changelog.d/5557.misc new file mode 100644 index 000000000000..76cb038f8b49 --- /dev/null +++ b/changelog.d/5557.misc @@ -0,0 +1 @@ +GC logging is now at the DEBUG level, not INFO. From a03b24b44ee69416f15764c9a78bb5edc7ac73d2 Mon Sep 17 00:00:00 2001 From: "Amber H. Brown" Date: Fri, 28 Jun 2019 21:04:38 +1000 Subject: [PATCH 3/4] debug when 0, but print level 1 and 2 GCs --- synapse/metrics/__init__.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/synapse/metrics/__init__.py b/synapse/metrics/__init__.py index 7d7fcdb9d0d3..eaf0aaa86e89 100644 --- a/synapse/metrics/__init__.py +++ b/synapse/metrics/__init__.py @@ -437,7 +437,10 @@ def f(*args, **kwargs): counts = gc.get_count() for i in (2, 1, 0): if threshold[i] < counts[i]: - logger.debug("Collecting gc %d", i) + if i == 0: + logger.debug("Collecting gc %d", i) + else: + logger.info("Collecting gc %d", i) start = time.time() unreachable = gc.collect(i) From d101492b4d72d98eb570c961a772ea0a86944112 Mon Sep 17 00:00:00 2001 From: "Amber H. Brown" Date: Fri, 28 Jun 2019 21:05:30 +1000 Subject: [PATCH 4/4] debug when 0, but print level 1 and 2 GCs --- changelog.d/5557.misc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog.d/5557.misc b/changelog.d/5557.misc index 76cb038f8b49..0c90f498719f 100644 --- a/changelog.d/5557.misc +++ b/changelog.d/5557.misc @@ -1 +1 @@ -GC logging is now at the DEBUG level, not INFO. +Logging when running GC collection on generation 0 is now at the DEBUG level, not INFO.