Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove POST method from password reset submit_token endpoint #6056

Merged
merged 5 commits into from
Sep 19, 2019
Merged

Remove POST method from password reset submit_token endpoint #6056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
499ab38
Fix password reset POST submit_token endpoint
anoadragon453 Sep 18, 2019
e55c127
Add changelog
anoadragon453 Sep 18, 2019
ea93a21
Remove POST method instead
anoadragon453 Sep 18, 2019
f4e60a5
Update changelog
anoadragon453 Sep 18, 2019
42f58ae
Merge branch 'develop' of github.com:matrix-org/synapse into anoa/fix…
anoadragon453 Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/6056.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove POST method from password reset submit_token endpoint until we implement submit_url functionality.
17 changes: 0 additions & 17 deletions synapse/rest/client/v2_alpha/account.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,23 +272,6 @@ def on_GET(self, request, medium):
request.write(html.encode("utf-8"))
finish_request(request)

@defer.inlineCallbacks
def on_POST(self, request, medium):
if medium != "email":
raise SynapseError(
400, "This medium is currently not supported for password resets"
)

body = parse_json_object_from_request(request)
assert_params_in_dict(body, ["sid", "client_secret", "token"])

valid, _ = yield self.store.validate_threepid_session(
body["sid"], body["client_secret"], body["token"], self.clock.time_msec()
)
response_code = 200 if valid else 400

return response_code, {"success": valid}


class PasswordRestServlet(RestServlet):
PATTERNS = client_patterns("/account/password$")
Expand Down