From a424d62998127a0232477c9f2895d42879eba665 Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Mon, 29 Jun 2020 13:51:23 +0100 Subject: [PATCH 1/3] Add comment explaining the purpose of the tests conditional req --- synapse/python_dependencies.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/synapse/python_dependencies.py b/synapse/python_dependencies.py index 92d3709ae38f..b1cac901eb92 100644 --- a/synapse/python_dependencies.py +++ b/synapse/python_dependencies.py @@ -93,6 +93,10 @@ "oidc": ["authlib>=0.14.0"], "systemd": ["systemd-python>=231"], "url_preview": ["lxml>=3.5.0"], + # Dependencies which are exclusively required by unit test code. This is + # NOT a list of all modules that are necessary to run the unit tests. + # Tests assume that all optional dependencies are installed. + # # parameterized_class decorator was introduced in parameterized 0.7.0 "test": ["mock>=2.0", "parameterized>=0.7.0"], "sentry": ["sentry-sdk>=0.7.2"], From cde5b715c5d8b605b78fe4a23be53449ef2c7c37 Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Mon, 29 Jun 2020 13:54:24 +0100 Subject: [PATCH 2/3] Add changelog --- changelog.d/7751.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/7751.misc diff --git a/changelog.d/7751.misc b/changelog.d/7751.misc new file mode 100644 index 000000000000..93fe5fa3ea1d --- /dev/null +++ b/changelog.d/7751.misc @@ -0,0 +1 @@ +Explain the "test" conditional requirement for dependencies are not all of the modules necessary to run the unit tests. \ No newline at end of file From 804d82c1934ae72ac92192d1fcaafda95481bd31 Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Mon, 29 Jun 2020 13:55:34 +0100 Subject: [PATCH 3/3] grammar --- changelog.d/7751.misc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog.d/7751.misc b/changelog.d/7751.misc index 93fe5fa3ea1d..eb10ecd92e5d 100644 --- a/changelog.d/7751.misc +++ b/changelog.d/7751.misc @@ -1 +1 @@ -Explain the "test" conditional requirement for dependencies are not all of the modules necessary to run the unit tests. \ No newline at end of file +Explain the "test" conditional requirement for dependencies is not all of the modules necessary to run the unit tests.