From 53f9e80fce1d892c79085ed5fd1cfd34c5da41d1 Mon Sep 17 00:00:00 2001
From: Mats Pfeiffer <mats.pfeiffer@googlemail.com>
Date: Thu, 8 Mar 2018 21:20:49 +0100
Subject: [PATCH] fix(top-app-bar): Remove validator & add attribute around
 default slot

---
 components/top-app-bar/README.md     |  5 ++++-
 components/top-app-bar/TopAppBar.vue | 18 ++++++++----------
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/components/top-app-bar/README.md b/components/top-app-bar/README.md
index a4238cc9f..43ff8008a 100644
--- a/components/top-app-bar/README.md
+++ b/components/top-app-bar/README.md
@@ -1,5 +1,8 @@
 ## TopAppBar
 
+Actually the mdc-web component enforces users to set a navigation icon, so be sure to set an icon
+in the navigation slot!
+
 ### Markup
 
 ```html
@@ -23,7 +26,7 @@
 
 | Event | Description |
 |------|------|
-| navigation | will be dispatched when navigation item is clicked |
+| onNavigation | will be dispatched when navigation item is clicked |
 
 ### Slots
 
diff --git a/components/top-app-bar/TopAppBar.vue b/components/top-app-bar/TopAppBar.vue
index 47da7282e..41263c8d4 100644
--- a/components/top-app-bar/TopAppBar.vue
+++ b/components/top-app-bar/TopAppBar.vue
@@ -1,13 +1,18 @@
 <template>
   <header
     class="mdc-top-app-bar"
+    :class="classes"
     @MDCTopAppBar:nav="onNavigation()">
     <div class="mdc-top-app-bar__row">
       <section
         class="mdc-top-app-bar__section mdc-top-app-bar__section--align-start"
         v-if="$slots['navigation'] || $slots['default']">
         <slot name="navigation"/>
-        <slot/>
+        <div
+          v-if="$slots['default']"
+          class="mdc-top-app-bar__title">
+          <slot/>
+        </div>
       </section>
       <section
         class="mdc-top-app-bar__section mdc-top-app-bar__section--align-end"
@@ -26,7 +31,6 @@ export default {
   props: {
     collapsed: {
       type: Boolean,
-      validator: value => value === this.short ? value : false,
       default: false
     },
     short: {
@@ -43,17 +47,11 @@ export default {
     classes () {
       return {
         'mdc-top-app-bar--short': this.short,
-        'mdc-top-app-bar--short-collapsed': this.collapsed
+        'mdc-top-app-bar--short-collapsed': this.collapsed && this.short
       }
     }
   },
   mounted () {
-    if (this.$slots.default) {
-      this.$slots.default.map(n => {
-        n.elm.classList.add('mdc-top-app-bar__title')
-      })
-    }
-
     if (this.$slots.navigation) {
       this.$slots.navigation.map(n => {
         n.elm.classList.add('mdc-top-app-bar__navigation-icon')
@@ -73,7 +71,7 @@ export default {
   },
   methods: {
     onNavigation () {
-      this.$emit('navigation')
+      this.$emit('onNavigation')
     }
   }
 }