From 97c1fe6ec8446056372cecf5fac4cd72e1c94e52 Mon Sep 17 00:00:00 2001
From: Fabien <fabien@dossierfacile.fr>
Date: Fri, 5 Jul 2024 15:56:59 +0200
Subject: [PATCH] chore: add logs and force transactional on addFiles

---
 .../api/front/register/AbstractDocumentSaveStep.java   | 10 ++++------
 .../api/front/service/DocumentServiceImpl.java         |  2 +-
 .../common/service/DocumentHelperServiceImpl.java      |  2 +-
 3 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/dossierfacile-api-tenant/src/main/java/fr/dossierfacile/api/front/register/AbstractDocumentSaveStep.java b/dossierfacile-api-tenant/src/main/java/fr/dossierfacile/api/front/register/AbstractDocumentSaveStep.java
index 9d78bdc1e..62f9c151d 100644
--- a/dossierfacile-api-tenant/src/main/java/fr/dossierfacile/api/front/register/AbstractDocumentSaveStep.java
+++ b/dossierfacile-api-tenant/src/main/java/fr/dossierfacile/api/front/register/AbstractDocumentSaveStep.java
@@ -5,23 +5,21 @@
 import fr.dossierfacile.api.front.model.tenant.TenantModel;
 import fr.dossierfacile.api.front.register.form.DocumentForm;
 import fr.dossierfacile.api.front.service.interfaces.DocumentService;
-import fr.dossierfacile.common.enums.LogType;
-import fr.dossierfacile.common.utils.TransactionalUtil;
 import fr.dossierfacile.common.entity.Document;
 import fr.dossierfacile.common.entity.Tenant;
+import fr.dossierfacile.common.enums.LogType;
 import fr.dossierfacile.common.enums.PartnerCallBackType;
 import fr.dossierfacile.common.enums.TenantFileStatus;
 import fr.dossierfacile.common.model.log.EditionType;
 import fr.dossierfacile.common.repository.TenantCommonRepository;
 import fr.dossierfacile.common.service.interfaces.LogService;
 import fr.dossierfacile.common.service.interfaces.PartnerCallBackService;
+import fr.dossierfacile.common.utils.TransactionalUtil;
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.transaction.annotation.Transactional;
 
-import java.io.IOException;
-
 @RequiredArgsConstructor
 @Slf4j
 public abstract class AbstractDocumentSaveStep<T extends DocumentForm> implements SaveStep<T> {
@@ -69,8 +67,8 @@ protected final void saveFiles(DocumentForm documentForm, Document document) {
                     try {
                         // TODO -> We must find a way to inform user there is a failure
                         documentService.addFile(file, document);
-                    } catch (IOException ioe) {
-                        log.error("Unable to add File ", ioe);
+                    } catch (Exception ioe) {
+                        log.error("Unable to add File to document {}", document.getId(), ioe);
                     }
                 });
     }
diff --git a/dossierfacile-api-tenant/src/main/java/fr/dossierfacile/api/front/service/DocumentServiceImpl.java b/dossierfacile-api-tenant/src/main/java/fr/dossierfacile/api/front/service/DocumentServiceImpl.java
index 542ac897c..b6aa9b118 100644
--- a/dossierfacile-api-tenant/src/main/java/fr/dossierfacile/api/front/service/DocumentServiceImpl.java
+++ b/dossierfacile-api-tenant/src/main/java/fr/dossierfacile/api/front/service/DocumentServiceImpl.java
@@ -129,7 +129,7 @@ public void resetValidatedOrInProgressDocumentsAccordingCategories(List<Document
                 });
     }
 
-    @Transactional(propagation = Propagation.SUPPORTS)
+    @Transactional
     @Override
     public void addFile(MultipartFile multipartFile, Document document) throws IOException {
         File file = documentHelperService.addFile(multipartFile, document);
diff --git a/dossierfacile-common-library/src/main/java/fr/dossierfacile/common/service/DocumentHelperServiceImpl.java b/dossierfacile-common-library/src/main/java/fr/dossierfacile/common/service/DocumentHelperServiceImpl.java
index 1b358938a..cae47a96c 100644
--- a/dossierfacile-common-library/src/main/java/fr/dossierfacile/common/service/DocumentHelperServiceImpl.java
+++ b/dossierfacile-common-library/src/main/java/fr/dossierfacile/common/service/DocumentHelperServiceImpl.java
@@ -39,7 +39,7 @@ public class DocumentHelperServiceImpl implements DocumentHelperService {
     private final SharedFileRepository fileRepository;
     private final EncryptionKeyService encryptionKeyService;
 
-    @Transactional(propagation = Propagation.SUPPORTS)
+    @Transactional
     @Override
     public File addFile(MultipartFile multipartFile, Document document) throws IOException {