Ensure watch (d)iff command finds staged files #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when "d" was pressed in watch mode, we were using `git ls-files` to find the list of new and modified files. If a file was modified but staged/cached (i.e. it was added with `git add` but not yet committed), it would not be detected. This commit changes the diff implementation to use `git status` instead, which lists both staged and un-staged changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when "d" was pressed in watch mode, we were using
git ls-filesto find the list of new and modified files. If a file was modified but staged/cached (i.e. it was added withgit addbut not yet committed), it would not be detected.This commit changes the diff implementation to use
git statusinstead, which lists both staged and un-staged changes.