Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test due to listen gem warning on Ruby 3.4 #36

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

mattbrictson
Copy link
Owner

The listen gem has an undeclared dependency on logger, which causes a warning to be printed in Ruby 3.4:

listen-3.9.0/lib/listen.rb:3: warning: logger was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.5.0. Add logger to your Gemfile or gemspec.

This causes one of our integration tests to fail, because we expect no warnings to be printed when running mt.

This needs to be fixed upstream in the listen gem (a PR is already open: guard/listen#581). For now, work around the problem by ignoring this particular warning.

@mattbrictson mattbrictson added the 🏠 Housekeeping Non-user facing cleanup and maintenance label Jul 2, 2024
@mattbrictson mattbrictson merged commit 62cbb5d into main Jul 2, 2024
6 checks passed
@mattbrictson mattbrictson deleted the workaround-listen-warning branch July 2, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏠 Housekeeping Non-user facing cleanup and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant