195: throw exception on non string values #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ariety of illegal key values (different object types) to test as well as testing that a legal value (String) works for sure.
|
I believe this PR would fix both #195 and #184. Is there anything against merging this @lviggiano? |
|
Hi. There is nothing against merging. I need to review and evaluate. Since I've been having health problems I am nomore doing any coding, and I am busy with other activities. When I can, I will proceed. |
lviggiano
force-pushed
the
master
branch
2 times, most recently
from
1b8f02f
to
cd3dc86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with null values being returned when an import contains a non-string value for a key.
Fixes issue #195.