Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After adding a server on the Settings page, focus remains at "Add new server" link #446

Closed
3 tasks done
jasonblais opened this issue Feb 21, 2017 · 0 comments
Closed
3 tasks done

After adding a server on the Settings page, focus remains at "Add new server" link #446

jasonblais opened this issue Feb 21, 2017 · 0 comments
Labels
All Platforms null Hacktoberfest null Help Wanted Type/Bug
Milestone
v4.0.0

Comments

@jasonblais
Copy link
Contributor

I confirm (by marking "x" in the [ ] below):

Summary
After adding a server on the Settings page, focus remains at "Add new server" link

Steps to reproduce

  1. Go to File > Settings
  2. Click "Add new server"
  3. Hit Cancel

Expected behavior
Focus should be away from "Add new server" link

Observed behavior
Focus is on the "Add new server" link
image

PS: This reproduces for "Edit" and "Remove" buttons too
@jasonblais jasonblais added this to the v3.7.0 milestone Feb 21, 2017
@jasonblais jasonblais changed the title After adding a server on the Settings page, focus remains at "Add new server" link [Help Wanted] After adding a server on the Settings page, focus remains at "Add new server" link Feb 26, 2017
@jasonblais jasonblais removed this from the v3.7.0 milestone Mar 16, 2017
@jasonblais jasonblais changed the title [Help Wanted] After adding a server on the Settings page, focus remains at "Add new server" link After adding a server on the Settings page, focus remains at "Add new server" link Mar 22, 2017
@jasonblais jasonblais modified the milestones: v3.9.0/3.10.0, Unscheduled Mar 22, 2017
@jasonblais jasonblais modified the milestones: v3.10.0, Unscheduled May 12, 2017
wvds pushed a commit to wvds/desktop that referenced this issue Oct 1, 2017
Remove focus after cancelling modal
9acaa36 
Closes mattermost#446
@wvds wvds mentioned this issue Oct 1, 2017
Merged
3 tasks
@jasonblais jasonblais modified the milestones: v3.10.0, v3.8.0 Oct 4, 2017
wvds pushed a commit to wvds/desktop that referenced this issue Oct 7, 2017
Move removing focus to TeamList.jsx
b5bc340 
Closes mattermost#446
yuya-oc added a commit that referenced this issue Oct 7, 2017
@yuya-oc
Merge pull request #607 from wvds/GH-446
85a1b34 
Remove focus after cancelling modal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
All Platforms null Hacktoberfest null Help Wanted Type/Bug
Projects
None yet
Milestone
v4.0.0
Development

No branches or pull requests
1 participant
@jasonblais