Settings not saved when changing tray icon theme

[CromFr]

I confirm (by marking "x" in the [ ] below):

• This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/.
• This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
• I have read contributing guidelines.

---

Summary
Settings not saved when changing tray icon theme

Steps to reproduce

• Operating System: Archlinux
• Mattermost Desktop App version 3.6.0
• Mattermost Server version: 3.6.0 (3.6.2)
• Clear steps to reproduce the issue
  • Go to file/settings
  • Try to change the tray icon theme

Expected behavior

"Settings saved" toast, and settings effective & saved (after restarting mattermost-desktop)

Observed behavior

Tray icon theme is still on the last value set.
Also, if you change another setting after changing the tray icon, everything works as expected

Possible fixes

maybe the save settings callback is not called with radio buttons?

---

nice issue template btw :)

[jasonblais]

@yuya-oc can you help take a look? Potentially a critical bug

[yuya-oc]

@CromFr Thanks for feedback. Yeah, auto-saving is missing in callback of radio buttons as you mentioned. So we need to fix.

[jasonblais]

To confirm, does this mean we should do 3.6.1 for Linux?

Is it only for the theme setting change?

[yuya-oc]

@jasonblais Ah, I didn't think about that.

As far as I read the codes again, only theme doesn't start auto-saving. As reported in original observed behavior, fortunately the theme is saved by changing another app option. So I feel we can cut v3.6.1.

[jasonblais]

I'm not really familiar with the Linux UI - how common is it to change the theme option?

It sounds like it might be a one-time change, for which there's a workaround for now (changing another app option). So I'm not sure it warrants a v3.6.1, although we should fix it for v3.7 of course.

[jasonblais]

Closed by #465, thanks @CromFr and @yuya-oc!