Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply a maximum server tab width of 17px #518

Closed
3 tasks done
jasonblais opened this issue Apr 26, 2017 · 1 comment · Fixed by #760
Closed
3 tasks done

Apply a maximum server tab width of 17px #518

jasonblais opened this issue Apr 26, 2017 · 1 comment · Fixed by #760

Comments

@jasonblais
Copy link
Contributor

I confirm (by marking "x" in the [ ] below):


Summary
Add a maximum server tab width of 17px

Steps to reproduce

Create a very long server tab name, 40-50 characters long

Expected behavior

Server name is truncated (common in web browsers such as Firefox)

image

Observed behavior

The entire server name appears in the tab bar. This can cause issues where if you have two or three servers each with a long server name, the last one isn't visible on the desktop app UI
image

Possible fixes

Add a maximum server tab width of 17px. This should fit up to 20 character server names.

If the name doesn't fit within 17px, the server name should be truncated with ... at the end.

@jasonblais
Copy link
Contributor Author

^@yuya-oc feel free to comment if you feel the 17px limit is too restrictive, but I estimated it based on the Firefox browser tab widths.

(in Chrome, the browser tab width auto-adjusts based on how many tabs you have open, but I don't think we need that since it's not likely for a user to belong to a lot of Mattermost instances at once)

@jasonblais jasonblais modified the milestones: v3.9.0, Unscheduled May 12, 2017
@jasonblais jasonblais modified the milestones: v3.10.0, v3.9.0 Jul 20, 2017
@jasonblais jasonblais removed the Hacktoberfest null label Nov 3, 2017
@jasonblais jasonblais changed the title Add a maximum server tab width of 17px Apply a maximum server tab width of 17px Nov 24, 2017
@amyblais amyblais removed this from the v4.2.0 milestone Mar 21, 2018
@jasonblais jasonblais added this to the v4.1.0 milestone Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants