Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop notifications don't show up, if the window has been minimized when it was INACTIVE. #522

Closed
3 tasks done
lip-d opened this issue Apr 30, 2017 · 4 comments
Closed
3 tasks done

Comments

@lip-d
Copy link
Contributor

lip-d commented Apr 30, 2017

I confirm (by marking "x" in the [ ] below):


Summary
Notification balloon doesn't show up, if the window has been minimized when it was INACTIVE.

Steps to reproduce

  1. Select any channel for this test (We call it "channel A" for simplicity)
  2. Make the app window inactive (ex. by clicking on the other window)
  3. Click on the "minimize" button on the title bar of Mattermost window.
  4. Send a message to the channel A from the other account.
    -> Notification balloon does not show up.

Note: The same issue occurs when you click on "close" button instead of "minimize".

Tested on:

  • Windows 7 32bit
  • Mattermost Desktop 3.6.0
  • Mattermost Server 3.8.0

Expected behavior
Notification balloon shows up at the task tray.

Observed behavior
Notification balloon does not show up.

Possible fixes
This might be related to:
desktop/src/main/mainWindow.js: line 88
" window.blur()" works well when the window is active, but not when the window is inactive.
I'm just guessing...

@lip-d lip-d changed the title Balloon doesn't show up, if the application window has been minimized when the window was INACTIVE. Notification balloon doesn't show up, if the window has been minimized when it was INACTIVE. Apr 30, 2017
@yuya-oc yuya-oc changed the title Notification balloon doesn't show up, if the window has been minimized when it was INACTIVE. Desktop notifications don't show up, if the window has been minimized when it was INACTIVE. Apr 30, 2017
@yuya-oc
Copy link
Contributor

yuya-oc commented Apr 30, 2017

Reproduced for me on Windows 10. And not on Mac. The step looks exact.

I believe the line 88 is not related because only closing calls the line.

@jasonblais Please let me confirm. On v3.8.0 server, does a new message show a desktop notification when the window is active and the message arrives to the current channel? I feel webview is accidentally active when reproducing the issue.

@jasonblais
Copy link
Contributor

jasonblais commented Apr 30, 2017

Thanks for the report @lip-d! Also able to reproduce on Windows 10 Home.

@yuya-oc In Mattermost server v3.6.0 and later , if the window is active (e.g. if you're viewing channel A), then no desktop notification is sent.

So it sounds like the webview might become active after clicking on the minimize/close buttons as you say. This would explain why no desktop notification is sent.

@yuya-oc
Copy link
Contributor

yuya-oc commented Jun 6, 2017

Closed via #545

@yuya-oc yuya-oc closed this as completed Jun 6, 2017
@lip-d
Copy link
Contributor Author

lip-d commented Jun 7, 2017

@yuya-oc and @jasonblais.
Thanks a lot! Really appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants