Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font/render size not persisted #564

Closed
3 tasks done
dmke opened this issue Jul 25, 2017 · 5 comments
Closed
3 tasks done

Font/render size not persisted #564

dmke opened this issue Jul 25, 2017 · 5 comments

Comments

@dmke
Copy link

dmke commented Jul 25, 2017

I confirm (by marking "x" in the [ ] below):


Summary

Changing the font size does not persist accross app restarts.

Steps to reproduce

  1. open Mattermost Desktop (v3.7.0)
  2. hit Ctrl++ or Ctrl+- to change font size
  3. close and restart Mattermost Destop

I'm using Debian Jessie v8.9 under GNOME 3.14.4 and Mattermost Server v4.0.2; but neither of this should matter.

Expected behavior

The selected font/render size after the app restart (step 3) should be the same as in step 2.

Observed behavior

It is not. The font/render size falls back to the default.

Possible fixes

Store the last selected font/render size locally upon change.

@yuya-oc
Copy link
Contributor

yuya-oc commented Jul 25, 2017

Thanks for feedback. I confirmed that on Windows 10. And the next v3.8.0 would fix the problem. Unfortunately its date is not decided yet.

@yuya-oc yuya-oc added this to the v3.8.0 milestone Jul 25, 2017
@jasonblais
Copy link
Contributor

@yuya-oc Do you think this was fixed by an Electron update?

@yuya-oc
Copy link
Contributor

yuya-oc commented Jul 25, 2017

@jasonblais Ah, yes. I forgot writing that. Electron 1.6.4 fixed zoom resetting. https://github.com/electron/electron/releases/tag/v1.6.4

@yuya-oc yuya-oc added the Electron null label Jul 25, 2017
@jasonblais
Copy link
Contributor

Thanks! Sounds good.

@dmke I'll close this ticket -- the fix will be available in Mattermost Desktop App v3.8.

@dmke
Copy link
Author

dmke commented Jul 25, 2017

Wow, that was fast. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants