Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Windows, Desktop notification duration settings in Control Panel not honoured since v3.7.1 #601

Closed
lip-d opened this issue Sep 10, 2017 · 6 comments
Milestone

Comments

@lip-d
Copy link
Contributor

lip-d commented Sep 10, 2017

I confirm (by marking "x" in the [ ] below):


Summary
On Windows, Desktop notification duration settings in Control Panel not honoured since version 3.7.1.

Steps to reproduce
On Windows:

  1. [Control Panel] -> [Ease of Access] -> [Make it easier to focus on tasks] -> [Adjust time limits and flashing visuals]
  2. Change the duration to 30 sec for instance. (Any duration greater than 5 sec)
  3. Receive a message on Mattermost desktop app (specifically version 3.7.1)
  • Operating System
    Windows 7
  • Mattermost Desktop App version
    3.7.1.
  • Mattermost Server version
    4.2.0 or any version.

Expected behavior
Desktop notification balloon stays open for more than 5 sec.

Observed behavior
Desktop notification balloon stays open only for 5 sec regardless of the Control Panel settings.

Possible fixes
I am not sure but I assume that this issue is related to the upgrade from 3.7.0 to 3.7.1.
(Maybe related to Electron upgrade to 1.6.10)
I've looked into the source code but failed to find the right place to fix.
I have disability and 5 sec is too short for me to click on the balloon. It would be amazing if this issue can be solved.
Thanks for all your effort to make this app amazing.
Best.

@yuya-oc
Copy link
Contributor

yuya-oc commented Sep 11, 2017

I haven't known the setting, thanks!

Since v3.7.1, we changed notifications from system tray balloon to Electron's one in order to solve #67.

Notification is implemented at brightray. I feel here is the place to set its duration. And the duration seems to be stored as HKEY_CURRENT_USER¥Control Panel¥Accessibility¥MessageDuration in registry. So we might be able to reflect it by creating a PR against to Electron.

@jasonblais jasonblais added this to the v3.10.0 milestone Sep 11, 2017
@yuya-oc
Copy link
Contributor

yuya-oc commented Sep 18, 2017

Added the PR. electron/electron#10517

@amyblais
Copy link
Member

I tested this and I didn't see this issue (desktop notification balloon stays open for more than 5 sec).

@lindy65
Copy link

lindy65 commented Feb 14, 2018

I also tested this (Win10) and it's working as expected for me.

@lip-d
Copy link
Contributor Author

lip-d commented Feb 15, 2018

ok on Win10, and not ok on Win7(4 sec).

  • Mattermost desktop app 4.0.0

@yuya-oc yuya-oc mentioned this issue Feb 22, 2018
3 tasks
@yuya-oc
Copy link
Contributor

yuya-oc commented Feb 22, 2018

Closed by #711

@yuya-oc yuya-oc closed this as completed Feb 22, 2018
@yuya-oc yuya-oc modified the milestones: v4.2.0, v4.1.0 Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants