Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BASH-2 Bundle Mac Desktop App as DMG #588

Merged
merged 1 commit into from
Jun 25, 2018
Merged

BASH-2 Bundle Mac Desktop App as DMG #588

merged 1 commit into from
Jun 25, 2018

Conversation

csduarte
Copy link
Contributor

@csduarte csduarte commented Sep 8, 2017 •
edited
Loading

Description
Changed build config for mac to generate DMG. User experience is much better when installing via DMG.

Test Cases
run : npm run package:mac
Execute the resulting Mattermost-xxx.dmg file.

screen shot 2017-09-07 at 12 51 04 pm

@yuya-oc
Copy link
Contributor

yuya-oc commented Sep 9, 2017

@jasonblais I had told about this problem before. We are using Linux when cutting a release, but dmg requires Mac. I think mattermost-mobile should have same problem when building iOS app. How do you do that?

@yuya-oc yuya-oc added the MacOS label Sep 9, 2017
@csduarte
Copy link
Contributor Author

@jasonblais This would not be a blocker for our team. We could add this in during our build process, but would love to have it as part of the platform as it improves the delivery. Most applications are offered as a signed product in DMG format, similar like the mobile app. I'd suggest finding a delivery that allows proper signing.

@jasonblais jasonblais added this to the v3.8.0 milestone Sep 15, 2017
@jasonblais
Copy link
Contributor

@yuya-oc Jonathan has a ticket to automate the build process and code-signing for Windows and Mac

https://mattermost.atlassian.net/browse/PLT-7540

Once that ticket is resolved, will that let us introduce the DMG file as well?

@yuya-oc
Copy link
Contributor

yuya-oc commented Sep 18, 2017

@jasonblais Yeah, we need to continue using tar.gz in CI because of Linux, but we can use dmg when cutting releases.

@jasonblais
Copy link
Contributor

Thanks! Added the Pending label for now, and we'll talk to Jonathan about the JIRA ticket (PLT-7540). We were planning to automate the build process and code-signing in the next few weeks.

@jasonblais
Copy link
Contributor

Work on PLT-7540 tentatively scheduled to start next week (for automating the build process and code-signing for Mac and Windows apps).

yuya-oc
yuya-oc approved these changes Sep 27, 2017
View reviewed changes
Copy link
Contributor

@yuya-oc yuya-oc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem in changes. We can design the background image and text/icon size later.

@jasonblais jasonblais modified the milestones: v3.8.0, v3.9.0 Oct 30, 2017
@jasonblais jasonblais mentioned this pull request Nov 19, 2017
Closed
@yuya-oc yuya-oc mentioned this pull request Jan 20, 2018
Merged
3 tasks
@jasonblais jasonblais mentioned this pull request Feb 1, 2018
Closed
3 tasks
@dmeza dmeza force-pushed the BASH-2_BundleMacDesktopApp_DMG branch from 9893091 to 9a6d1ad Compare March 8, 2018 21:42
@dmeza
Copy link
Contributor

dmeza commented Mar 8, 2018 •
edited
Loading

Rebased to latest and added fixes to copy the right file for mac (.dmg) and updated electron-builder version so that it can properly build on HighSierra.

@amyblais amyblais removed this from the v4.1.0 milestone Mar 21, 2018
@jasonblais
Copy link
Contributor

#676 has changed ownership, and is in the process of being finished up. After that we should be able to review and merge this PR

@jasonblais jasonblais mentioned this pull request Apr 2, 2018
Merged
3 tasks
yuya-oc
yuya-oc suggested changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@yuya-oc yuya-oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csduarte @dmeza Thank you for waiting. Now we're ready to get dmg. Would you rebase this against to the latest master?

electron-builder.json Outdated
"NOTICE.txt"
]
}
"dmg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of dmg and zip are needed because upcoming auto-updater will use zip.

yuya-oc
yuya-oc reviewed Jun 22, 2018
View reviewed changes
electron-builder.json
]
},
"dmg": {
"background": "resources/osx/DMG_BG.png",
"iconSize": 140,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to specify size here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mattermost/mattermost-webapp#208 (comment)

Note: We might make change when creating our own background.

yuya-oc
yuya-oc reviewed Jun 22, 2018
View reviewed changes
scripts/cp_artifacts.sh Outdated
@@ -10,7 +10,7 @@ cp "${SRC}/Mattermost-${VERSION}-ia32-win.zip" "${DEST}/mattermost-desktop-${VER
cp "${SRC}/win/Mattermost Setup ${VERSION}.exe" "${DEST}/mattermost-setup-${VERSION}-win64.exe"
cp "${SRC}/win-ia32/Mattermost Setup ${VERSION}-ia32.exe" "${DEST}/mattermost-setup-${VERSION}-win32.exe"

cp "${SRC}/Mattermost-${VERSION}-mac.tar.gz" "${DEST}/mattermost-desktop-${VERSION}-mac.tar.gz"
cp "${SRC}/Mattermost-${VERSION}.dmg" "${DEST}/mattermost-desktop-${VERSION}.dmg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dmg is not generated in CircleCI. So you don't have to modify this script.

electron-builder.json Outdated
@@ -50,17 +50,14 @@
"mac": {
"category": "public.app-category.productivity",
"target": [
"tar.gz"
],
"extraResources": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest electron-builder.json should have proper config for extra resources. So you would not have to remove this config.

@dmeza dmeza force-pushed the BASH-2_BundleMacDesktopApp_DMG branch from 9a6d1ad to 71250ad Compare June 24, 2018 03:39
@dmeza dmeza force-pushed the BASH-2_BundleMacDesktopApp_DMG branch from 71250ad to bfbf189 Compare June 24, 2018 03:53
@yuya-oc yuya-oc merged commit 5009075 into mattermost:master Jun 25, 2018
@yuya-oc yuya-oc added this to the v4.2.0 milestone Jun 25, 2018
@yuya-oc yuya-oc removed the Pending label Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MusikPolice MusikPolice MusikPolice approved these changes

@yuya-oc yuya-oc yuya-oc approved these changes

Assignees
No one assigned
Labels
MacOS
Projects
None yet
Milestone
v4.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@csduarte @yuya-oc @jasonblais @dmeza @MusikPolice @amyblais