BASH-23 Add npm clean script #597
Conversation
package.json
Outdated
| @@ -20,6 +20,7 @@ | |||
| "build:main": "cross-env NODE_ENV=production webpack --bail --config webpack.config.main.js", | |||
| "build:renderer": "cross-env NODE_ENV=production webpack --bail --config webpack.config.renderer.js", | |||
| "start": "electron src --disable-dev-mode", | |||
| "clean":"rm -rf dist/ release/ node_modules/ src/node_modules/ build/ browser/**/*_bundle.js}", | |||
There was a problem hiding this comment.
You should remove src/**/*_bundle.js instead of browser/**/*_bundle.js to remove src/main_bundle.js.
package.json
Outdated
| @@ -20,6 +20,7 @@ | |||
| "build:main": "cross-env NODE_ENV=production webpack --bail --config webpack.config.main.js", | |||
| "build:renderer": "cross-env NODE_ENV=production webpack --bail --config webpack.config.renderer.js", | |||
| "start": "electron src --disable-dev-mode", | |||
| "clean":"rm -rf dist/ release/ node_modules/ src/node_modules/ build/ browser/**/*_bundle.js}", | |||
There was a problem hiding this comment.
- missing a white space after
clean:. - there is unexpected trailing token
}.
|
@yuya-oc rebased to latest. Fixed all your comments built, packaged and run linting. Let me know if that's the correct change. |
|
Thanks @dmeza! But sorry, I missed one thing. |
|
@yuya-oc yeah, it did not work so I added these two: |
package.json
Outdated
| @@ -20,6 +20,7 @@ | |||
| "build:main": "cross-env NODE_ENV=production webpack --bail --config webpack.config.main.js", | |||
| "build:renderer": "cross-env NODE_ENV=production webpack --bail --config webpack.config.renderer.js", | |||
| "start": "electron src --disable-dev-mode", | |||
| "clean": "rm -rf dist/ release/ node_modules/ src/node_modules/ build/ src/*_bundle.js src/**/*_bundle.js", | |||
There was a problem hiding this comment.
Is rm -rf dist/ release/ node_modules/ src/node_modules/ build/ && find src -name '*_bundle.js' | xargs rm appropriate for you? This can remove src/browser/webview/mattermost_bundle.js
There was a problem hiding this comment.
@yuya-oc changed and tested.
package.json
Outdated
| @@ -20,6 +20,7 @@ | |||
| "build:main": "cross-env NODE_ENV=production webpack --bail --config webpack.config.main.js", | |||
| "build:renderer": "cross-env NODE_ENV=production webpack --bail --config webpack.config.renderer.js", | |||
| "start": "electron src --disable-dev-mode", | |||
| "clean": "rm -rf dist/ release/ node_modules/ src/node_modules/ build/ src/*_bundle.js src/**/*_bundle.js", | |||
There was a problem hiding this comment.
dist and build are not used in this project. Is it necessary explicitly removing them?
There was a problem hiding this comment.
@yuya-oc: I thought I saw that some updates didn't get picked up because those folders already existed. If this is wrong, we should remove those from the clean task.
There was a problem hiding this comment.
@dmeza Yeah, please remove. Those folders were actually used in past versions, so I think that you possibly saw them.
There was a problem hiding this comment.
@yuya-oc removed dist and build folders from the clean script.
Description
Adds a simple rm command to npm to remove all dynamically generated files to make it easy to reset between builds/branches
npm run lint:jsfor proper code formattingTest Cases
Run
npm run clean