diff --git a/.circleci/config.yml b/.circleci/config.yml index a873772888e..ea7dda258ca 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -550,14 +550,14 @@ workflows: - test filters: branches: - only: /^build-pr-.*/ + only: /^(build|android)-pr-.*/ - build-ios-pr: context: mattermost-mobile-ios-pr requires: - test filters: branches: - only: /^build-pr-.*/ + only: /^(build|ios)-pr-.*/ - build-android-unsigned: context: mattermost-mobile-unsigned diff --git a/app/components/autocomplete/at_mention/at_mention.js b/app/components/autocomplete/at_mention/at_mention.js index 1bc74fc016e..583a9ffaba2 100644 --- a/app/components/autocomplete/at_mention/at_mention.js +++ b/app/components/autocomplete/at_mention/at_mention.js @@ -251,15 +251,16 @@ export default class AtMention extends PureComponent { return ( ); } diff --git a/app/components/autocomplete/channel_mention/channel_mention.js b/app/components/autocomplete/channel_mention/channel_mention.js index 1608446eaee..b53a28af5a1 100644 --- a/app/components/autocomplete/channel_mention/channel_mention.js +++ b/app/components/autocomplete/channel_mention/channel_mention.js @@ -225,15 +225,16 @@ export default class ChannelMention extends PureComponent { return ( ); } diff --git a/app/components/autocomplete/emoji_suggestion/__snapshots__/emoji_suggestion.test.js.snap b/app/components/autocomplete/emoji_suggestion/__snapshots__/emoji_suggestion.test.js.snap index f1b65b1055b..2bdcc0c8595 100644 --- a/app/components/autocomplete/emoji_suggestion/__snapshots__/emoji_suggestion.test.js.snap +++ b/app/components/autocomplete/emoji_suggestion/__snapshots__/emoji_suggestion.test.js.snap @@ -3036,7 +3036,7 @@ exports[`components/autocomplete/emoji_suggestion should match snapshot 2`] = ` numColumns={1} onEndReachedThreshold={2} pageSize={10} - removeClippedSubviews={false} + removeClippedSubviews={true} renderItem={[Function]} scrollEventThrottle={50} style={ diff --git a/app/components/autocomplete/emoji_suggestion/emoji_suggestion.js b/app/components/autocomplete/emoji_suggestion/emoji_suggestion.js index 3f53eac06c0..da5e8135a46 100644 --- a/app/components/autocomplete/emoji_suggestion/emoji_suggestion.js +++ b/app/components/autocomplete/emoji_suggestion/emoji_suggestion.js @@ -230,6 +230,7 @@ export default class EmojiSuggestion extends PureComponent { extraData={this.state} data={this.state.dataSource} keyExtractor={this.keyExtractor} + removeClippedSubviews={true} renderItem={this.renderItem} pageSize={10} initialListSize={10} diff --git a/app/components/autocomplete/slash_suggestion/__snapshots__/slash_suggestion.test.tsx.snap b/app/components/autocomplete/slash_suggestion/__snapshots__/slash_suggestion.test.tsx.snap index adbb00233ed..e6a7c7a7896 100644 --- a/app/components/autocomplete/slash_suggestion/__snapshots__/slash_suggestion.test.tsx.snap +++ b/app/components/autocomplete/slash_suggestion/__snapshots__/slash_suggestion.test.tsx.snap @@ -37,7 +37,7 @@ exports[`components/autocomplete/slash_suggestion should match snapshot 1`] = ` nestedScrollEnabled={false} numColumns={1} onEndReachedThreshold={2} - removeClippedSubviews={false} + removeClippedSubviews={true} renderItem={[Function]} scrollEventThrottle={50} style={ diff --git a/app/components/autocomplete/slash_suggestion/slash_suggestion.tsx b/app/components/autocomplete/slash_suggestion/slash_suggestion.tsx index a31714d129e..f8342e0cf85 100644 --- a/app/components/autocomplete/slash_suggestion/slash_suggestion.tsx +++ b/app/components/autocomplete/slash_suggestion/slash_suggestion.tsx @@ -265,6 +265,7 @@ export default class SlashSuggestion extends PureComponent { extraData={this.state} data={this.state.dataSource} keyExtractor={this.keyExtractor} + removeClippedSubviews={true} renderItem={this.renderItem} nestedScrollEnabled={nestedScrollEnabled} /> diff --git a/app/components/emoji_picker/__snapshots__/emoji_picker.test.js.snap b/app/components/emoji_picker/__snapshots__/emoji_picker.test.js.snap index 94cd1bdb563..dbeaadc324f 100644 --- a/app/components/emoji_picker/__snapshots__/emoji_picker.test.js.snap +++ b/app/components/emoji_picker/__snapshots__/emoji_picker.test.js.snap @@ -103,7 +103,7 @@ exports[`components/emoji_picker/emoji_picker.ios should match snapshot 1`] = ` onScroll={[Function]} onScrollToIndexFailed={[Function]} pageSize={50} - removeClippedSubviews={false} + removeClippedSubviews={true} renderItem={[Function]} renderSectionHeader={[Function]} scrollEventThrottle={50} diff --git a/app/components/emoji_picker/emoji_picker_base.js b/app/components/emoji_picker/emoji_picker_base.js index 5bfc3a19f5e..264c52ee5ad 100644 --- a/app/components/emoji_picker/emoji_picker_base.js +++ b/app/components/emoji_picker/emoji_picker_base.js @@ -264,15 +264,16 @@ export default class EmojiPicker extends PureComponent { listComponent = ( ); @@ -292,7 +293,7 @@ export default class EmojiPicker extends PureComponent { onScroll={this.onScroll} onScrollToIndexFailed={this.handleScrollToSectionFailed} pageSize={50} - removeClippedSubviews={false} + removeClippedSubviews={true} renderItem={this.renderItem} renderSectionHeader={this.renderSectionHeader} sections={emojis} diff --git a/app/components/post_list/__snapshots__/post_list.test.js.snap b/app/components/post_list/__snapshots__/post_list.test.js.snap index 8df39d6fd56..a5c1bf5f7e8 100644 --- a/app/components/post_list/__snapshots__/post_list.test.js.snap +++ b/app/components/post_list/__snapshots__/post_list.test.js.snap @@ -57,7 +57,7 @@ exports[`PostList setting channel deep link 1`] = ` tintColor="#3d3c40" /> } - removeClippedSubviews={false} + removeClippedSubviews={true} renderItem={[Function]} scrollEventThrottle={60} style={ @@ -134,7 +134,7 @@ exports[`PostList setting permalink deep link 1`] = ` tintColor="#3d3c40" /> } - removeClippedSubviews={false} + removeClippedSubviews={true} renderItem={[Function]} scrollEventThrottle={60} style={ @@ -211,7 +211,7 @@ exports[`PostList should match snapshot 1`] = ` tintColor="#3d3c40" /> } - removeClippedSubviews={false} + removeClippedSubviews={true} renderItem={[Function]} scrollEventThrottle={60} style={ diff --git a/app/components/post_list/post_list.js b/app/components/post_list/post_list.js index 52a75e30fd5..40c9d1f2bf1 100644 --- a/app/components/post_list/post_list.js +++ b/app/components/post_list/post_list.js @@ -516,7 +516,7 @@ export default class PostList extends PureComponent { onScrollToIndexFailed={this.handleScrollToIndexFailed} ref={this.flatListRef} refreshControl={refreshControl} - removeClippedSubviews={false} + removeClippedSubviews={true} renderItem={this.renderItem} scrollEventThrottle={60} style={styles.flex} diff --git a/app/components/sidebars/main/channels_list/filtered_list/filtered_list.js b/app/components/sidebars/main/channels_list/filtered_list/filtered_list.js index d5e18b4fd77..266a1bcc2f2 100644 --- a/app/components/sidebars/main/channels_list/filtered_list/filtered_list.js +++ b/app/components/sidebars/main/channels_list/filtered_list/filtered_list.js @@ -383,6 +383,7 @@ class FilteredList extends Component { diff --git a/app/screens/recent_mentions/recent_mentions.js b/app/screens/recent_mentions/recent_mentions.js index 8312589861b..2d0f1b69d2d 100644 --- a/app/screens/recent_mentions/recent_mentions.js +++ b/app/screens/recent_mentions/recent_mentions.js @@ -214,6 +214,7 @@ export default class RecentMentions extends PureComponent { keyExtractor={this.keyExtractor} keyboardShouldPersistTaps='always' keyboardDismissMode='interactive' + removeClippedSubviews={true} renderItem={this.renderPost} onViewableItemsChanged={this.onViewableItemsChanged} /> diff --git a/app/screens/saved_posts/saved_posts.js b/app/screens/saved_posts/saved_posts.js index f9cdf3a13b7..febb834a2e1 100644 --- a/app/screens/saved_posts/saved_posts.js +++ b/app/screens/saved_posts/saved_posts.js @@ -219,6 +219,7 @@ export default class SavedPosts extends PureComponent { keyExtractor={this.keyExtractor} keyboardShouldPersistTaps='always' keyboardDismissMode='interactive' + removeClippedSubviews={true} renderItem={this.renderPost} onViewableItemsChanged={this.onViewableItemsChanged} /> diff --git a/app/screens/search/__snapshots__/search.test.js.snap b/app/screens/search/__snapshots__/search.test.js.snap index 448c6b91fcf..082ed59cdee 100644 --- a/app/screens/search/__snapshots__/search.test.js.snap +++ b/app/screens/search/__snapshots__/search.test.js.snap @@ -98,6 +98,7 @@ exports[`Search should match snapshot 1`] = ` onLayout={[Function]} onScroll={[Function]} onViewableItemsChanged={[Function]} + removeClippedSubviews={true} renderSectionHeader={[Function]} scrollEventThrottle={60} sections={ diff --git a/app/screens/search/search.js b/app/screens/search/search.js index a15a048d1d9..a179a3429ae 100644 --- a/app/screens/search/search.js +++ b/app/screens/search/search.js @@ -747,6 +747,7 @@ export default class Search extends PureComponent { { style={styles.flex} sections={sections} ItemSeparatorComponent={renderItemSeparator} + removeClippedSubviews={true} renderItem={renderItem} renderSectionHeader={renderSectionHeader} keyExtractor={keyExtractor} diff --git a/share_extension/screens/team_list.tsx b/share_extension/screens/team_list.tsx index 56f6ab0f644..447273d8383 100644 --- a/share_extension/screens/team_list.tsx +++ b/share_extension/screens/team_list.tsx @@ -76,6 +76,7 @@ const TeamList = () => { testID='share_extension.team_list.screen' data={teams} ItemSeparatorComponent={renderItemSeparator} + removeClippedSubviews={true} renderItem={renderItem} keyExtractor={keyExtractor} keyboardShouldPersistTaps='always'