Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cld 6410 revisit build release process #109

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

phoinixgrr
Copy link
Contributor

@phoinixgrr phoinixgrr commented Oct 26, 2023

Summary

Aligning makefile to the standardized template

  • We are aligning the makefile to the standardized template, along with the changes required for this project.
  • We are also refactoring CI to compensate for these changes.

Now building and packaging for most architectures and operating systems.
Next step is to integrate this to the Unified CI system.

Ticket Link

Ticket: https://mattermost.atlassian.net/browse/CLD-6410

@phoinixgrr phoinixgrr force-pushed the CLD-6410-revisit-build-release-process branch 2 times, most recently from 4e055a0 to 52df696 Compare October 26, 2023 14:46
@phoinixgrr phoinixgrr force-pushed the CLD-6410-revisit-build-release-process branch from eef9e6e to e0c1935 Compare November 9, 2023 17:16
@phoinixgrr phoinixgrr assigned toninis and mvitale1989 and unassigned mvitale1989 and toninis Nov 9, 2023
@phoinixgrr phoinixgrr marked this pull request as ready for review November 9, 2023 17:17
@phoinixgrr phoinixgrr force-pushed the CLD-6410-revisit-build-release-process branch from e0c1935 to 1d2c621 Compare November 9, 2023 17:20
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks! Left non-blocking question.

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
We are alligning the makefile to the standardized template, along with the changes required for this project.
We are also  refactoring CI to compensate for these changes.

Now building and packaging for most architectures and operating systems.

Signed-off-by: Akis Maziotis <akis.maziotis@mattermost.com>
@phoinixgrr phoinixgrr force-pushed the CLD-6410-revisit-build-release-process branch from 1d2c621 to 84462b9 Compare November 12, 2023 08:36
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the update-dependencies target any more. I think you perhaps misunderstood my comment. When I said we don't use vendoring, I meant we don't need the go mod vendor line. The other lines were fine. But it's okay, no need to put it back again.

@phoinixgrr phoinixgrr merged commit 699831b into master Nov 13, 2023
6 checks passed
@phoinixgrr phoinixgrr deleted the CLD-6410-revisit-build-release-process branch November 13, 2023 08:05
phoinixgrr added a commit that referenced this pull request Nov 14, 2023
With the changes introduced under #109
We missed the `logs` directory from the tarbal generation.

We fix this now.

before:
```
├── LICENSE.txt
├── NOTICE.txt
├── README.md
├── bin
│   └── mattermost-push-proxy
└── config
    ├── build.txt
    └── mattermost-push-proxy.sample.json
```

after:
```
├── LICENSE.txt
├── NOTICE.txt
├── README.md
├── bin
│   └── mattermost-push-proxy
├── config
│   ├── build.txt
│   └── mattermost-push-proxy.sample.json
└── logs
```
phoinixgrr added a commit that referenced this pull request Nov 15, 2023
With the changes introduced under #109
We missed the `logs` directory from the tarbal generation.

We fix this now.

before:
```
├── LICENSE.txt
├── NOTICE.txt
├── README.md
├── bin
│   └── mattermost-push-proxy
└── config
    ├── build.txt
    └── mattermost-push-proxy.sample.json
```

after:
```
├── LICENSE.txt
├── NOTICE.txt
├── README.md
├── bin
│   └── mattermost-push-proxy
├── config
│   ├── build.txt
│   └── mattermost-push-proxy.sample.json
└── logs
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants