-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cld 6410 revisit build release process #109
Conversation
4e055a0
to
52df696
Compare
eef9e6e
to
e0c1935
Compare
e0c1935
to
1d2c621
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks! Left non-blocking question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
We are alligning the makefile to the standardized template, along with the changes required for this project. We are also refactoring CI to compensate for these changes. Now building and packaging for most architectures and operating systems. Signed-off-by: Akis Maziotis <akis.maziotis@mattermost.com>
1d2c621
to
84462b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the update-dependencies
target any more. I think you perhaps misunderstood my comment. When I said we don't use vendoring, I meant we don't need the go mod vendor
line. The other lines were fine. But it's okay, no need to put it back again.
With the changes introduced under #109 We missed the `logs` directory from the tarbal generation. We fix this now. before: ``` ├── LICENSE.txt ├── NOTICE.txt ├── README.md ├── bin │ └── mattermost-push-proxy └── config ├── build.txt └── mattermost-push-proxy.sample.json ``` after: ``` ├── LICENSE.txt ├── NOTICE.txt ├── README.md ├── bin │ └── mattermost-push-proxy ├── config │ ├── build.txt │ └── mattermost-push-proxy.sample.json └── logs ```
With the changes introduced under #109 We missed the `logs` directory from the tarbal generation. We fix this now. before: ``` ├── LICENSE.txt ├── NOTICE.txt ├── README.md ├── bin │ └── mattermost-push-proxy └── config ├── build.txt └── mattermost-push-proxy.sample.json ``` after: ``` ├── LICENSE.txt ├── NOTICE.txt ├── README.md ├── bin │ └── mattermost-push-proxy ├── config │ ├── build.txt │ └── mattermost-push-proxy.sample.json └── logs ```
Summary
Aligning makefile to the standardized template
Now building and packaging for most architectures and operating systems.
Next step is to integrate this to the Unified CI system.
Ticket Link
Ticket: https://mattermost.atlassian.net/browse/CLD-6410