MM-55060 - Calls: Add PushTypeCalls for calls-specific push notifications

[cpoile]

Summary

• This is to support calls-specific push notifications, see also:

  • MM-55060 - Calls: Add PushTypeCalls for calls-specific push notifications mattermost-plugin-calls#561
  • MM-55060 - Calls: Add PushTypeCalls for calls-specific push notifications mattermost#25405
  • MM-55036 - Calls: Fix: Receiving in-app notifications for calls notifications while active mattermost-mobile#7623

• This exposes a /version route right beside the existing /root route. It's not under the api because it's not part of the api (imo). I renamed the git_hash to build_hash which is more accurate (esp considering we're also showing the git_version, which is the version of git, not of the proxy, so pretty confusing). I also shortened it to the short hash because there's no real reason to expose the full hash.

• The /version route will be requested once per calls plugin reload (in the onActivate).

• This lets Calls be backward compatible with older push proxies and use correct typing in the future for calls push notification messages, which allows us to internationalize the call started push messages in calls v1.0.

• I tagged Agniva on these because he was doing the push-proxy recently, but please review these too @enahum if you wish.

• NOTE: will need to bump to 5.27.0 after this is merged for the Calls code to work.

Ticket Link

• https://mattermost.atlassian.net/browse/MM-55060

[github-actions]

Unit Test Results

17 tests  ±0   17 ✔️ ±0   16s ⏱️ ±0s
  3 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit f45900b. ± Comparison against base commit d41f502.

[agnivade]

Heads up that there are some changes to the Makefile here: #109.

[cpoile]

Thanks, merged and updated the Makefile.

[streamer45]

Nicely done!

[enahum]

This approach solves the new plugin + new proxy + new app, but what about the other cases?

For example what if the app is not up to date?

Perhaps we should have a quick convo about this if you want me to clarify.

In my mind, regardless of the combination of elements: server, proxy, plugin, app. The notification should work as was already introduced. Backwards compatibility needs to be kept to avoid bug reports

[cpoile]

@enahum Excellent point, overlooked that. Fixed (see: mattermost/mattermost#25405 (comment) ) for an explanation. Thank you!

[enahum]

@cpoile thanks for the change.. now it seems to take care of the backwards compatibility

[streamer45]

@cpoile Is the /version endpoint used anywhere after the recent changes? I am okay with keeping it but I suppose it's not strictly needed any longer?

[cpoile]

@streamer45 Nope, but I did want to keep it so that it's there in previous versions if we ever do need it in the future.