Get status code from Firebase error #126
Conversation
| return 0, false | ||
| } | ||
|
|
||
| response, ok := errorValue.FieldByName("Response").Interface().(*http.Response) |
There was a problem hiding this comment.
The "internal error encountered" is actually coming from this function NewFirebaseErrorOnePlatform, which tries to parse a GCP error into a firebase error. So what we need is just the ErrorCode field which is what should be considered as the actual status code from my reading.
All of this is so badly written, because the error string doesn't even contain the status code which would have solved all our problems in the start.
| @@ -178,7 +180,16 @@ func (me *AndroidNotificationServer) SendNotification(msg *PushNotification) Pus | |||
| } | |||
|
|
|||
| if err != nil { | |||
| me.logger.Errorf("Failed to send FCM push sid=%v did=%v err=%v type=%v", msg.ServerID, msg.DeviceID, err, me.AndroidPushSettings.Type) | |||
| statusCode, hasStatusCode := getStatusCode(err) | |||
There was a problem hiding this comment.
I think we can be bit smart about hasStatusCode and dynamically add the statusCode to the error string if hasStatusCode is true. Otherwise use the original string.
Long term, we should move to structured logging which makes all of this very simple. But out of scope for now.
larkox
added
2: Reviews Complete
|
/update-branch |
Summary
Log firebase error status code along the error itself
Ticket Link
NONE