Fix CircleCI config and test in Python 3 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it did run: https://circleci.com/workflow-run/9968e9f0-aafc-4dd3-be3d-22d7d3e6d3bd Status hasn't showed up here, though it started showing up in #36 so maybe it's working now. |
|
Hey @mattloper it'd be great to have a working CI setup for this repo. Could you merge this? There are also a few niceties in #36 which it'd be great to have shipped. Thanks! |
|
Thanks Matt! |
|
Thank you Paul! And sorry for delays; I'll try to be more responsive in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Matt! Thanks for merging my PRs 😁
My bad on this config I added in #27. Looks like I had truncated it by mistake. Here's the correct config from the fork.
Added: For this to build, it looks like you'll have to configure Circle to "build forked pull requests."