Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridLines renamed in v3 #77

Open
SaltySeaSlug opened this issue Mar 9, 2022 · 3 comments
Open

GridLines renamed in v3 #77

SaltySeaSlug opened this issue Mar 9, 2022 · 3 comments

Comments

@SaltySeaSlug
Copy link

Hi,

Just want to bring to your attention;

GridLines has been renamed in Chart.js v3.x to Grid along with a few other changes in property names

https://www.chartjs.org/docs/3.7.1/getting-started/v3-migration.html#ticks

@mattosaurus
Copy link
Owner

Hi, thanks for pointing that out. I think I've updated all the relevant properties now and have published v3.1.0 with the changes but let me know if you spot anything else I've missed.

@SaltySeaSlug
Copy link
Author

Hi,

Noticed that common properties for axes are missing from your scale base;
Few were removed from the Tick and Time classes respectively;

scales.[x/y]Axes.ticks.beginAtZero was renamed to scales[id].beginAtZero

/* MERGED PROPERTIES */
scales.[x/y]Axes.ticks.max was renamed to scales[id].max
scales.[x/y]Axes.ticks.min was renamed to scales[id].min
scales.[x/y]Axes.time.max was renamed to scales[id].max
scales.[x/y]Axes.time.min was renamed to scales[id].min

scales.[x/y]Axes.ticks.reverse was renamed to scales[id].reverse
scales.[x/y]Axes.ticks.suggestedMax was renamed to scales[id].suggestedMax
scales.[x/y]Axes.ticks.suggestedMin was renamed to scales[id].suggestedMin

https://www.chartjs.org/docs/3.7.1/axes/#common-options-to-all-axes

@mattosaurus
Copy link
Owner

Thanks, the axes had changed more than I'd expected. I've updated these and pushed out v3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants