Fix ReSharper warnings

mattwcole · Feb 16, 2021 · 09d255e · 09d255e
1 parent 76aaef2
commit 09d255e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/src/Gelf.Extensions.Logging/HttpGelfClient.cs b/src/Gelf.Extensions.Logging/HttpGelfClient.cs
@@ -24,12 +24,9 @@ public HttpGelfClient(GelfLoggerOptions options)
  Timeout = options.HttpTimeout
  };
 
- if (options.HttpHeaders != null)
+ foreach (var header in options.HttpHeaders)
  {
- foreach (var header in options.HttpHeaders)
- {
- _httpClient.DefaultRequestHeaders.Add(header.Key, header.Value);
- }
+ _httpClient.DefaultRequestHeaders.Add(header.Key, header.Value);
  }
  }
 

diff --git a/test/Gelf.Extensions.Logging.Tests/GelfLoggerTests.cs b/test/Gelf.Extensions.Logging.Tests/GelfLoggerTests.cs
@@ -7,6 +7,9 @@
 using Microsoft.Extensions.Logging;
 using Xunit;
 
+// ReSharper disable TemplateIsNotCompileTimeConstantProblem
+// ReSharper disable InconsistentLogPropertyNaming
+
 namespace Gelf.Extensions.Logging.Tests
 {
  public abstract class GelfLoggerTests : IDisposable
@@ -39,7 +42,7 @@ public async Task Sends_message_to_Graylog(LogLevel logLevel, int expectedLevel)
  var messageText = Faker.Lorem.Sentence();
  var sut = LoggerFixture.CreateLogger<GelfLoggerTests>();
 
- sut.Log(logLevel, new EventId(), (object) null, null, (s, e) => messageText);
+ sut.Log(logLevel, new EventId(), (object) null, null, (_, _) => messageText);
 
  var message = await GraylogFixture.WaitForMessageAsync();
 

diff --git a/test/Gelf.Extensions.Logging.Tests/HttpGelfLoggerTests.cs b/test/Gelf.Extensions.Logging.Tests/HttpGelfLoggerTests.cs
@@ -11,7 +11,7 @@ public HttpGelfLoggerTests(HttpGraylogFixture graylogFixture) : base(graylogFixt
  Host = GraylogFixture.Host,
  Port = graylogFixture.InputPort,
  Protocol = GelfProtocol.Http,
- LogSource = typeof(HttpGelfLoggerTests).Name
+ LogSource = nameof(HttpGelfLoggerTests)
  }))
  {
  }

diff --git a/test/Gelf.Extensions.Logging.Tests/UdpGelfLoggerTests.cs b/test/Gelf.Extensions.Logging.Tests/UdpGelfLoggerTests.cs
@@ -3,6 +3,8 @@
 using Microsoft.Extensions.Logging;
 using Xunit;
 
+// ReSharper disable TemplateIsNotCompileTimeConstantProblem
+
 namespace Gelf.Extensions.Logging.Tests
 {
  public class UdpGelfLoggerTests : GelfLoggerTests, IClassFixture<UdpGraylogFixture>
@@ -13,7 +15,7 @@ public UdpGelfLoggerTests(UdpGraylogFixture graylogFixture) : base(graylogFixtur
  Host = GraylogFixture.Host,
  Port = graylogFixture.InputPort,
  Protocol = GelfProtocol.Udp,
- LogSource = typeof(UdpGelfLoggerTests).Name
+ LogSource = nameof(UdpGelfLoggerTests)
  }))
  {
  }