Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🔨 Added Dockerfile for development #743

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: 🔨 Added Dockerfile for development #743

wants to merge 2 commits into from

Conversation

jcardenas3
Copy link

@jcardenas3 jcardenas3 commented Nov 13, 2024 •
edited
Loading

  • Added a Dockerfile for development.
  • Added a git safe directory called /build to avoid git refusing commands.
  • Adjusted docker-run.sh script to use the gow package to run the mautrix-whatsapp binary specifying the parameters for config file and registration file.

tulir
tulir reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@tulir tulir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why people want to use docker for development when it's much easier to just develop outside docker, but I guess it can be added if it doesn't affect anything else

build.sh Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulir tulir tulir left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcardenas3 @tulir