From 84eb78a4018ca475224403aed582541c8edb8474 Mon Sep 17 00:00:00 2001 From: mike a Date: Mon, 5 Sep 2022 05:30:18 -0700 Subject: [PATCH] Closes #26750: refactoring --- .../fenix/home/sessioncontrol/SessionControlView.kt | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlView.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlView.kt index 8afb305329a3..b2cdb2e5c7d5 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlView.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlView.kt @@ -200,7 +200,8 @@ class SessionControlView( ) { val view: RecyclerView = containerView as RecyclerView - var isCFRDisplayed = false + // We want to limit feature recommendations to one per HomePage visit. + var featureRecommended = false var state: AppState? = null private val sessionControlAdapter = SessionControlAdapter( @@ -216,23 +217,23 @@ class SessionControlView( override fun onLayoutCompleted(state: RecyclerView.State?) { super.onLayoutCompleted(state) - if (!isCFRDisplayed && !context.settings().showHomeOnboardingDialog) { + if (!featureRecommended && !context.settings().showHomeOnboardingDialog) { if (context.settings().showSyncCFR) { - isCFRDisplayed = SyncCFRPresenter( + featureRecommended = SyncCFRPresenter( context = context, recyclerView = view, ).showSyncCFR() } if (context.settings().shouldShowJumpBackInCFR) { - isCFRDisplayed = JumpBackInCFRDialog(view).showIfNeeded() + featureRecommended = JumpBackInCFRDialog(view).showIfNeeded() } if (!context.settings().shouldShowJumpBackInCFR && context.settings().showWallpaperOnboarding && - !isCFRDisplayed + !featureRecommended ) { - isCFRDisplayed = + featureRecommended = interactor.showWallpapersOnboardingDialog(this@SessionControlView.state) } }