Skip to content

Commit

Permalink
Reduce max message size ring buffer in destruction test
Browse files Browse the repository at this point in the history
The default was increased in microsoft#5866, which made the destruction test to
fail more ofter because of unexpected destruction flow. This was
intended to fail on SGX due to out-of-memory and on virtual due to
max ringbuffer message size overflow.

After increasing the message limit we get the primary to slow (in
debug build, at least), so election happens and is messing up the
network, and so test can fail on missing primary or other states
it doesn't expect.

We mitigate the issue here by rolling back msg limit, but the proper
fix might be to rewrite the test to make it more robust.
  • Loading branch information
maxtropets committed Jul 18, 2024
1 parent 1721658 commit 6d18e1f
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tests/e2e_batched.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,5 +138,8 @@ def run_to_destruction(args):
args.package = "libjs_generic"
args.nodes = infra.e2e_args.min_nodes(args, f=1)

# Helps ensure expected destruction workflow. See #6373 for details.
args.max_msg_size_bytes = f"{1024 * 1024 * 16}" # 16MB

run(args)
run_to_destruction(args)

0 comments on commit 6d18e1f

Please sign in to comment.