Fix mutation to invalid hash pattern

[fix #1417]
mbj · Feb 9, 2024 · 81c58fc · 81c58fc
1 parent 42c0dad
commit 81c58fc
Show file tree

Hide file tree

Showing 8 changed files with 29 additions and 11 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -1,4 +1,7 @@
-# v0.11.28
+# v0.11.28 2024-02-09
+
+* [#1418](https://github.com/mbj/mutant/pull/1418)
+  Fix mutation to invalid pattern match.
 
 * [#1416](https://github.com/mbj/mutant/pull/1416)
   Fix CLI parsing issue where arguments given to `mutant environment` where silently ignored.

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mutant (0.11.27)
+    mutant (0.11.28)
       diff-lcs (~> 1.3)
       parser (~> 3.3.0)
       regexp_parser (~> 2.8.2)

diff --git a/lib/mutant/mutator/node/literal/hash.rb b/lib/mutant/mutator/node/literal/hash.rb
@@ -36,7 +36,9 @@ class Pair < Node
           private
 
             def dispatch
-              emit_key_mutations
+              emit_key_mutations do |mutation|
+                !mutation.eql?(s(:nil))
+              end
               emit_value_mutations
             end
 

diff --git a/lib/mutant/version.rb b/lib/mutant/version.rb
@@ -2,5 +2,5 @@
 
 module Mutant
   # Current mutant version
-  VERSION = '0.11.27'
+  VERSION = '0.11.28'
 end # Mutant
diff --git a/meta/case.rb b/meta/case.rb
@@ -1,5 +1,19 @@
 # frozen_string_literal: true
 
+Mutant::Meta::Example.add :case do
+  source <<-RUBY
+    case nil
+    in { a: nil }
+    end
+  RUBY
+
+  mutation <<~RUBY
+    case nil
+    in {a__mutant__: nil}
+    end
+  RUBY
+end
+
 Mutant::Meta::Example.add :case do
   source <<-RUBY
     case

diff --git a/meta/def.rb b/meta/def.rb
@@ -226,7 +226,6 @@
     mutation 'def foo(**); { ** }; end'
     mutation 'def foo(**); { default: nil }; end'
     mutation 'def foo(**); { default__mutant__: nil, ** }; end'
-    mutation 'def foo(**); { nil => nil, ** }; end'
     mutation 'def foo(**); {}; end'
   end
 

diff --git a/test_app/Gemfile.minitest.lock b/test_app/Gemfile.minitest.lock
@@ -1,15 +1,15 @@
 PATH
   remote: ..
   specs:
-    mutant (0.11.27)
+    mutant (0.11.28)
       diff-lcs (~> 1.3)
       parser (~> 3.3.0)
       regexp_parser (~> 2.8.2)
       sorbet-runtime (~> 0.5.0)
       unparser (~> 0.6.9)
-    mutant-minitest (0.11.27)
+    mutant-minitest (0.11.28)
       minitest (~> 5.11)
-      mutant (= 0.11.27)
+      mutant (= 0.11.28)
 
 GEM
   remote: https://oss:Px2ENN7S91OmWaD5G7MIQJi1dmtmYrEh@gem.mutant.dev/

diff --git a/test_app/Gemfile.rspec3.8.lock b/test_app/Gemfile.rspec3.8.lock
@@ -1,14 +1,14 @@
 PATH
   remote: ..
   specs:
-    mutant (0.11.27)
+    mutant (0.11.28)
       diff-lcs (~> 1.3)
       parser (~> 3.3.0)
       regexp_parser (~> 2.8.2)
       sorbet-runtime (~> 0.5.0)
       unparser (~> 0.6.9)
-    mutant-rspec (0.11.27)
-      mutant (= 0.11.27)
+    mutant-rspec (0.11.28)
+      mutant (= 0.11.28)
       rspec-core (>= 3.8.0, < 4.0.0)
 
 GEM