-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutation of super
to super()
should not happen for a method with no arguments
#615
Comments
@mvz I believe this is a duplicate of an existing issue we agreed upon fixing. Till I've the time to reference the original I'll keep it open. I agree on fixing it, while you cite #309 I do not agree its at all the same case. Even when this statement may spark new discussions on #309. Please do not, I do not want to lock down another discussion, hint, hint, hint. |
@mbj: I think this is the original issue for fixing |
Hah, I was actually curious on why that old issue showed up. Thx for clearing that up for me. |
Yeah, sorry about that xD |
This mutation only makes sense if the method was called with arguments in the first place. If there are no arguments `super()` and `super` are semantically equivalent. And there is no vector towards reduced semantics, which is required for an operator to be valid. If mutant would be able to emit this mutation conditionally (on the presence of arguments) than this is a valid operator. Until than we cannot emit it. [fix #615]
(Follow-up from #309).
It looks like mutant wants to enforce
super()
as opposed tosuper
, even when those two options are completely equivalent:Here, idiomatic Ruby would favor
super
oversuper()
, but mutant wants me to usesuper()
, and I see no way to write a spec to favorsuper
.The text was updated successfully, but these errors were encountered: