add back the taggables index in the taggings table #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seuros
added a commit
that referenced
this pull request
Jun 11, 2014
add back the taggables index in the taggings table
|
In the file of add_missing_taggable_index.acts_as_taggable_on_engine.rb, should we add back as below: |
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
add back the taggables index in the taggings table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #509
As explained in the bug, taggings_idx can only be used if tag_id is specified in the where clause due to the nature of compound indexes. This means the following query requires a full table scan: "what are all the tags on this taggable?"
This a regression that is fixed by re-adding a compound index on [:taggable_id, :taggable_type, :context]