Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclassing other base views #52

Open
hollyschilling opened this issue Mar 5, 2017 · 0 comments
Open

Subclassing other base views #52

hollyschilling opened this issue Mar 5, 2017 · 0 comments

Comments

@hollyschilling
Copy link

There are many different types of views that could be subclassed to make NibDesignable versions of them. The framework already includes many of them (UIView, UIControl, UITableViewCell, UITableViewHeaderFooterView, UICollectionViewCell, and UICollectionReusableView), but users may always have proprietary classes that may benefit from being subclassed.

Subclassing views within the framework is made trivial by the abstraction of NibDesignableProtocol and it's default implementation. However, the scoping of -setupNib() makes it difficult to do outside of that file. If the scope of that method were expanded to public (instead of fileprivate) it would greatly ease this task. Are there any obvious down sides to doing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant