Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Update actions to v2 and assumed role #686

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Chore: Update actions to v2 and assumed role #686

merged 2 commits into from
Oct 16, 2023

Conversation

krisrjohnson21
Copy link
Contributor

Summary of changes

Asana Ticket: Update application repos to use the new version of the GitHub action(s) (v2 tag)

This PR updates the deploy workflow to use v2 of the build-push-ecr and deploy-ecs actions. These updated actions assume an IAM role instead of relying on long-lasting AWS keys for an IAM user

@krisrjohnson21 krisrjohnson21 requested review from a team, dks-mbta and paulswartz October 16, 2023 15:25
@github-actions
Copy link

Coverage of commit e2ead7f

Summary coverage rate:
  lines......: 89.2% (4104 of 4600 lines)
  functions..: 70.9% (2225 of 3139 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@paulswartz paulswartz temporarily deployed to dev-green October 16, 2023 15:40 — with GitHub Actions Inactive
@paulswartz
Copy link
Member

Deploying to dev-green to double-check that it works.

paulswartz
paulswartz reviewed Oct 16, 2023
View reviewed changes
.github/workflows/deploy-prod.yml Outdated
id: build-push
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: do you still need the secret key here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I do not!

@github-actions
Copy link

Coverage of commit 6ca98e4

Summary coverage rate:
  lines......: 89.2% (4103 of 4600 lines)
  functions..: 70.9% (2225 of 3139 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

paulswartz
paulswartz approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@paulswartz paulswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@krisrjohnson21 krisrjohnson21 merged commit 41230ba into master Oct 16, 2023
6 checks passed
@krisrjohnson21 krisrjohnson21 deleted the github-actions-krj branch October 16, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulswartz paulswartz paulswartz approved these changes

@dks-mbta dks-mbta Awaiting requested review from dks-mbta dks-mbta was automatically assigned from mbta/transit-data

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krisrjohnson21 @paulswartz