feat(DebugView): trip, stop, vehicle ids #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaBrady
force-pushed
the
kb-debug-2
branch
2 times, most recently
from
27e95ea to
320ef8f
Compare
EmmaSimon
reviewed
Nov 14, 2024
| @@ -51,6 +51,7 @@ struct ContentView: View { | |||
| .onReceive(inspection.notice) { inspection.visit(self, $0) } | |||
| .onAppear { | |||
| Task { await contentVM.loadOnboardingScreens() } | |||
| Task { await nearbyVM.loadDebugSetting() } | |||
There was a problem hiding this comment.
I'm not seeing the debug info if I just toggle the setting on without restarting the app (and vice versa). I think the nearby VM needs to reload when the setting changes.
There was a problem hiding this comment.
If you haven't looked at this yet, I based the combined stop and trip details changes off of this branch (partly to use the debug view, partly to use the existing debug loading in nearby VM), and I just fixed it as part of that, so don't worry about getting it working in this PR, it's fine as an interim state on a debug feature flag only we'll see.
There was a problem hiding this comment.
Okay great, thank you!!
| if nearbyVM.showDebugMessages { | ||
| DebugView { | ||
| VStack { | ||
| Text(verbatim: "trip id \(tripId)") |
There was a problem hiding this comment.
nitpick: Add a : after trip id 😛
KaylaBrady
force-pushed
the
kb-debug-2
branch
from
c011106 to
3bfe4bd
Compare
KaylaBrady
force-pushed
the
kb-debug-2
branch
from
3bfe4bd to
d25a577
Compare
EmmaSimon
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Debug setting to show (trip, stop, vehicle, etc) IDs
What is this PR for?
This PR adds the low hanging fruit ids - trip, stop, and vehicle. I opted to add each element in the detail view (stop in stop details, trip & vehicle in trip details).
I didn't add anything around route patterns since our route pattern grouping logic is in flux - if we find it will be valuable, we can add that separately. I did take an initial pass at it and it would involve quite a bit of prop drilling unless we switch to using an EnvironmentObject to represent debug mode.
Testing
What testing have you done?
Added some unit tests & ran locally. Also checked formatting to address the DebugView expanding unexpectedly as raised in slack