Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend non-typical upcoming cutoff to 120 min #570

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

boringcactus
Copy link
Member

Summary

Ticket: Update lookahead from 90 to 120 minutes

There are no longer references to 90 minutes anywhere in the app.

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"

android

  • All user-facing strings added to strings resource

Testing

Updated the unit tests. Did not spend a ton of time trying to find a case where a pattern is filtered in at 120 minutes that was filtered out at 90, but it should be fine.

@boringcactus boringcactus requested a review from a team as a code owner December 5, 2024 21:29
@boringcactus boringcactus merged commit b83da3c into main Dec 6, 2024
7 checks passed
@boringcactus boringcactus deleted the mth-cutoff-120 branch December 6, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants