Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DownstreamAlerts): Exclude the target stop's alerts from downstream calc #571

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

KaylaBrady
Copy link
Collaborator

@KaylaBrady KaylaBrady commented Dec 6, 2024

Summary

Fix for Display downstream disruptions

What is this PR for?

This PR fixes an issue where within suspensions, users would see the alert for their stop in addition to a downstream "Suspension ahead" alert.

When calculating downstream alerts, we should exclude alerts at the current stop from consideration.

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"
      android
  • All user-facing strings added to strings resource

Testing

What testing have you done?

  • Added unit test
  • Ran locally, confirmed downstream alerts no longer showing up within the bounds of the current GL suspension alert
    IMG_0213

@KaylaBrady KaylaBrady requested a review from a team as a code owner December 6, 2024 21:58
@KaylaBrady KaylaBrady changed the title fix(DownstreamAlerts): Exclude the target stop's alerts from consider… fix(DownstreamAlerts): Exclude the target stop's alerts from downstream calc Dec 6, 2024
@KaylaBrady KaylaBrady force-pushed the kb-exclude-target-alerts-from-downstream branch from 1d904e1 to 7ffc024 Compare December 6, 2024 22:12
Copy link
Contributor

@JackVCurtis JackVCurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KaylaBrady KaylaBrady merged commit 777c18c into main Dec 11, 2024
7 checks passed
@KaylaBrady KaylaBrady deleted the kb-exclude-target-alerts-from-downstream branch December 11, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants