feat(Android): draw crosshair at selected location #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackVCurtis
reviewed
Dec 11, 2024
| ) | ||
| if ( | ||
| isNearbyNotFollowing && | ||
| lastNearbyTransitLocation != null && |
There was a problem hiding this comment.
🎱 (stylistic) hasStableNearbyTransitLocation would be help me here, I blame Ruby for my dislike of long booleans.
There was a problem hiding this comment.
I can't actually refactor this out because I'm relying on the lastNearbyTransitLocation != null to do smart casting within the if body.
JackVCurtis
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: 🤖 | Map | Crosshairs when map dragged
Adds the crosshair on the map.
iOS
android
Testing
Validated that the crosshair is being shown while panning, after panning, and during the momentum of a fling. The crosshair briefly flickers when it crosses over from outside the map to inside the map, but that's also the case on iOS.