feat: Update stop details navigation to match spec #586
+159
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+141
to
+142
| // If the new filter is nil and there is already a nil filter in the stack for the same stop ID, | ||
| // we don't want a duplicate unfiltered entry, so skip appending a new one |
There was a problem hiding this comment.
Should this condition really be inside the lastFilter != nil? It isn't in the other copy of this logic. (It would probably be worth refactoring this logic out somewhere else even if the result is a bit ugly at each call site.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Combined Stop + Trip Details: nav changes
This updates the combined stop/trip navigation to match the desired behavior. Back buttons are removed from the filtered and unflitered stop pages, and the X button on filtered stop details will bring you back to the place you came from, either the unfiltered stop or nearby transit. Because this doesn't involve changing the actual entry type, but just the stop filter on the entry, there's some slightly convoluted logic to ensure that filter entries are appended rather than replacing the unfiltered entry, and that when the filtered entries are removed, that they don't add duplicate unfiltered entries. This logic also unfortunately needs to exist in two places, since a new entry can be pushed in its entirety to the nearby VM, or the filter value can be modified independently through
lastStopDetailsFilter.iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?- [ ] Add temporary machine translations, marked "Needs Review"android
- [ ] All user-facing strings added to strings resourceTesting
Added tests for new behavior