From aeb429751c6386251bdd7fe13ef76d94db5f9235 Mon Sep 17 00:00:00 2001 From: Terry Moore Date: Sun, 12 Jun 2022 13:47:09 -0400 Subject: [PATCH 1/4] Fix #195: Update library.* with version 0.9.2-pre1 --- library.json | 2 +- library.properties | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/library.json b/library.json index 90d35fd..964b7a6 100644 --- a/library.json +++ b/library.json @@ -31,7 +31,7 @@ "authors": ["Terry Moore "] } ], - "version": "0.9.1", + "version": "0.9.2-pre1", "frameworks": "arduino", "platforms": "*" } diff --git a/library.properties b/library.properties index b432e33..14c382d 100644 --- a/library.properties +++ b/library.properties @@ -1,5 +1,5 @@ name=MCCI Arduino LoRaWAN Library -version=0.9.1 +version=0.9.2-pre1 author=Terry Moore, ChaeHee Won maintainer=Terry Moore sentence=High-level library for LoRaWAN-based Arduino end-devices. From 6c849cf1c4195d9045ca7798cb6f13437310abcf Mon Sep 17 00:00:00 2001 From: Terry Moore Date: Sun, 12 Jun 2022 13:45:20 -0400 Subject: [PATCH 2/4] Fix #194: missing return --- src/lib/arduino_lorawan_sessionstate.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lib/arduino_lorawan_sessionstate.cpp b/src/lib/arduino_lorawan_sessionstate.cpp index 12103ca..c1d447c 100644 --- a/src/lib/arduino_lorawan_sessionstate.cpp +++ b/src/lib/arduino_lorawan_sessionstate.cpp @@ -411,6 +411,7 @@ Arduino_LoRaWAN::ApplySessionState( LMIC_disableChannel(ch); } #endif + return true; } #undef FUNCTION From 5d900f384bba050f2d023753db7069ec624152f4 Mon Sep 17 00:00:00 2001 From: Terry Moore Date: Sun, 12 Jun 2022 13:53:26 -0400 Subject: [PATCH 3/4] This is v0.9.2-pre2 --- README.md | 4 +++- library.json | 2 +- library.properties | 2 +- src/Arduino_LoRaWAN.h | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 36b0197..57d411e 100644 --- a/README.md +++ b/README.md @@ -430,7 +430,9 @@ Much more elaborate uses can be found in the MCCI [Catena-Arduino-Platform](http - Head includes the following changes. - - Correct error in logging, missing `return true` in `Arduino_LoRaWAN::cEventLog::processSingleEvent()` ([#191](https://github.com/mcci-catena/arduino-lorawan/issues/169)). This is v0.9.2-pre1. + - Apply pre-release version to `library.properties` and `library.json` ([#195](https://github.com/mcci-catena/arduino-lorawan/issues/195)). This is v0.9.2-pre2. + - Correct error, missing `return true` at end of `Arduino_LoRaWAN::ApplySessionState()`. ([#194])(https://github.com/mcci-catena/arduino-lorawan/issues/194)). + - Correct error in logging, missing `return true` in `Arduino_LoRaWAN::cEventLog::processSingleEvent()` ([#191](https://github.com/mcci-catena/arduino-lorawan/issues/191)). This is v0.9.2-pre1. - v0.9.1 includes the following changes. diff --git a/library.json b/library.json index 964b7a6..b6ff772 100644 --- a/library.json +++ b/library.json @@ -31,7 +31,7 @@ "authors": ["Terry Moore "] } ], - "version": "0.9.2-pre1", + "version": "0.9.2-pre2", "frameworks": "arduino", "platforms": "*" } diff --git a/library.properties b/library.properties index 14c382d..3421607 100644 --- a/library.properties +++ b/library.properties @@ -1,5 +1,5 @@ name=MCCI Arduino LoRaWAN Library -version=0.9.2-pre1 +version=0.9.2-pre2 author=Terry Moore, ChaeHee Won maintainer=Terry Moore sentence=High-level library for LoRaWAN-based Arduino end-devices. diff --git a/src/Arduino_LoRaWAN.h b/src/Arduino_LoRaWAN.h index 58bfb65..07b338c 100644 --- a/src/Arduino_LoRaWAN.h +++ b/src/Arduino_LoRaWAN.h @@ -34,7 +34,7 @@ Copyright notice: /// \ref ARDUINO_LORAWAN_VERSION_COMPARE_LT() to compare relative versions. /// #define ARDUINO_LORAWAN_VERSION \ - ARDUINO_LORAWAN_VERSION_CALC(0, 9, 2, 1) /* v0.9.2-pre1 */ + ARDUINO_LORAWAN_VERSION_CALC(0, 9, 2, 2) /* v0.9.2-pre2 */ #define ARDUINO_LORAWAN_VERSION_GET_MAJOR(v) \ (((v) >> 24u) & 0xFFu) From e5545df08beeb4563f871cf853c22bb6dc5824b9 Mon Sep 17 00:00:00 2001 From: Terry Moore Date: Mon, 13 Jun 2022 22:05:53 -0400 Subject: [PATCH 4/4] Fix #196: -Wunused-parameter warnings --- README.md | 1 + library.json | 2 +- library.properties | 2 +- src/Arduino_LoRaWAN.h | 10 +++++++++- 4 files changed, 12 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 57d411e..00c00f3 100644 --- a/README.md +++ b/README.md @@ -430,6 +430,7 @@ Much more elaborate uses can be found in the MCCI [Catena-Arduino-Platform](http - Head includes the following changes. + - Fix `-Wunused-parameter` warnings from gcc. ([#196](https://github.com/mcci-catena/arduino-lorawan/issues/196)). This is v0.9.2-pre3. - Apply pre-release version to `library.properties` and `library.json` ([#195](https://github.com/mcci-catena/arduino-lorawan/issues/195)). This is v0.9.2-pre2. - Correct error, missing `return true` at end of `Arduino_LoRaWAN::ApplySessionState()`. ([#194])(https://github.com/mcci-catena/arduino-lorawan/issues/194)). - Correct error in logging, missing `return true` in `Arduino_LoRaWAN::cEventLog::processSingleEvent()` ([#191](https://github.com/mcci-catena/arduino-lorawan/issues/191)). This is v0.9.2-pre1. diff --git a/library.json b/library.json index b6ff772..ba72acf 100644 --- a/library.json +++ b/library.json @@ -31,7 +31,7 @@ "authors": ["Terry Moore "] } ], - "version": "0.9.2-pre2", + "version": "0.9.2-pre3", "frameworks": "arduino", "platforms": "*" } diff --git a/library.properties b/library.properties index 3421607..706a221 100644 --- a/library.properties +++ b/library.properties @@ -1,5 +1,5 @@ name=MCCI Arduino LoRaWAN Library -version=0.9.2-pre2 +version=0.9.2-pre3 author=Terry Moore, ChaeHee Won maintainer=Terry Moore sentence=High-level library for LoRaWAN-based Arduino end-devices. diff --git a/src/Arduino_LoRaWAN.h b/src/Arduino_LoRaWAN.h index 07b338c..9ad0044 100644 --- a/src/Arduino_LoRaWAN.h +++ b/src/Arduino_LoRaWAN.h @@ -34,7 +34,7 @@ Copyright notice: /// \ref ARDUINO_LORAWAN_VERSION_COMPARE_LT() to compare relative versions. /// #define ARDUINO_LORAWAN_VERSION \ - ARDUINO_LORAWAN_VERSION_CALC(0, 9, 2, 2) /* v0.9.2-pre2 */ + ARDUINO_LORAWAN_VERSION_CALC(0, 9, 2, 3) /* v0.9.2-pre3 */ #define ARDUINO_LORAWAN_VERSION_GET_MAJOR(v) \ (((v) >> 24u) & 0xFFu) @@ -844,6 +844,10 @@ class Arduino_LoRaWAN size_t nExtraSessionInfo ) { + MCCIADK_API_PARAMETER(SessionInfo); + MCCIADK_API_PARAMETER(pExtraSessionInfo); + MCCIADK_API_PARAMETER(nExtraSessionInfo); + // default: do nothing. } @@ -854,6 +858,8 @@ class Arduino_LoRaWAN SessionState &State ) { + MCCIADK_API_PARAMETER(State); + // default: not implemented. return false; } @@ -866,6 +872,8 @@ class Arduino_LoRaWAN const SessionState &State ) { + MCCIADK_API_PARAMETER(State); + // default: do nothing. }