-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List percentiles in output data, fixes #138 #144
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ed9361c
List percentiles instead of stddev for Latency, fixes #138
goto-bus-stop 274c535
use different percentiles, and the same for all stat types
goto-bus-stop 37e0d7f
Add API tests for percentile properties
goto-bus-stop 3381fc4
Update percentile property names [skip ci]
goto-bus-stop 3da1ffd
Fix latency table for new hdr-histogram-percentiles-obj.
goto-bus-stop 9344522
Fix formatting of Bytes/Sec
goto-bus-stop 7bafd6d
Bump hdr-histogram-percentiles-obj.
goto-bus-stop eb2dbc4
Use t.type() over t.ok() to assert numberic props exist
goto-bus-stop 56377f2
Document the results object.
goto-bus-stop 50e2fbb
Try a different table layout
goto-bus-stop 13fdfc3
Test existence of relevant percentiles
goto-bus-stop c597770
Increase tap test timeout, should fix appveyor flakiness
goto-bus-stop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -130,9 +130,9 @@ function run (opts, cb) { | |
title: opts.title, | ||
url: opts.url, | ||
socketPath: opts.socketPath, | ||
requests: histAsObj(requests, totalCompletedRequests), | ||
requests: addPercentiles(requests, histAsObj(requests, totalCompletedRequests)), | ||
latency: addPercentiles(latencies, histAsObj(latencies)), | ||
throughput: histAsObj(throughput, totalBytes), | ||
throughput: addPercentiles(throughput, histAsObj(throughput, totalBytes)), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you please add some tests that verify that those are there? |
||
errors: errors, | ||
timeouts: timeouts, | ||
duration: Math.round((Date.now() - startTime) / 1000), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a suggestion: rename
50%
toMedian
in both cases.